From: Stefan Bader <stefan.bader@canonical.com>
To: Matt Fleming <matt@console-pimps.org>
Cc: Pierre Ossman <pierre@ossman.eu>, Jens Axboe <axboe@kernel.dk>,
linux-kernel@vger.kernel.org, Andy Whitcroft <apw@canonical.com>
Subject: Re: [PATCH] mmc: prevent dangling block device from accessing stale queues
Date: Thu, 04 Jun 2009 21:23:31 +0200 [thread overview]
Message-ID: <4A281F33.80606@canonical.com> (raw)
In-Reply-To: <20090604191513.GA5702@console-pimps.org>
Matt Fleming wrote:
> On Thu, Jun 04, 2009 at 09:00:42PM +0200, Stefan Bader wrote:
>> Hm, not sure this is what you wanted to know... On the launchpad report
>> there are logs which I took with lots of printk's enabled. This shows that
>> after resume the queue receives a request from mmcblk0 (which no longer
>> exists) but uses the same pointer as mmcblk1 which was just created.
>>
>
> Maybe I'm missing something, but why is the device instance being
> destroyed during a suspend? E.g why do you have mmcblk0 before suspend and
> mmcblk1 after suspend?
That is the way mmcblock works (without unsafe resume set) in conjunction with
( probably ) slow userspace. On suspend the block device is removed. But the
mount is cleaned by (in that case hald) doing a forced unmount. The timeing
seems to be that the unmount part is partially done on the way up.
--
When all other means of communication fail, try words!
next prev parent reply other threads:[~2009-06-04 19:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-04 18:00 [PATCH] mmc: prevent dangling block device from accessing stale queues Stefan Bader
2009-06-04 18:29 ` Pierre Ossman
2009-06-04 19:00 ` Stefan Bader
2009-06-04 19:15 ` Matt Fleming
2009-06-04 19:22 ` Pierre Ossman
2009-06-04 19:23 ` Stefan Bader [this message]
2009-06-04 19:21 ` Pierre Ossman
2009-06-04 19:37 ` Stefan Bader
2009-06-10 21:02 ` Pavel Machek
2009-06-23 15:01 ` Stefan Bader
2009-07-01 11:09 ` Pierre Ossman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A281F33.80606@canonical.com \
--to=stefan.bader@canonical.com \
--cc=apw@canonical.com \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@console-pimps.org \
--cc=pierre@ossman.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox