Re: [PATCH] cpumask: alloc blank cpumask left over

Yinghai Lu
2009-06-05T05:57:55Z

Rusty Russell wrote:
> On Fri, 5 Jun 2009 06:31:31 am Yinghai Lu wrote:
>> avoid suprise when MAXSMP is enabled
>>
>> Signed-off-by: Yinghai Lu <yinghai.lu@kernel.org>
>
> I understand the temptation, but two questions arise:
> 1) Shouldn't we actually audit to see if any of these are currently problems,
those are defined as static cpumask_var_t, and if MAXSMP is not used, they are cleared already

> and
> 2) Should the non-MAXSMP alloc_cpumask_var_node (currently a noop) zero the
> mask if __GFP_ZERO is set?

No. in that case, should cpumask_clear instead.

YH