Re: [PATCH 4/6] x86/cpufreq: use cpumask_copy instead of =

Rusty Russell
2009-06-10T06:22:47Z

On Wed, 10 Jun 2009 02:11:08 am Linus Torvalds wrote:
> On Tue, 9 Jun 2009, Dave Jones wrote:
> > work_on_cpu()'s definition could probably use a fat comment describing
> > why it sucks.
>
> No, it should be renamed.
>
> The problem is that it _sounds_ like a nice thing to do.

Yeah, it used to be *faster* than the stupid mug-own-cpumask code it was
supposed to replace. Then we hit all those deadlocks using keventd, and
revulsion against YA per-cpu thread, and ended up with the current sucky
version.

Rusty.