Re: [Patch BUGFIX] kcore: fix its wrong size on x86_64

Américo Wang
2009-06-16T15:29:24Z

On Mon, Jun 15, 2009 at 6:08 PM, Eric W. Biederman<ebiederm@xmission.com> wrote:
> Amerigo Wang <xiyou.wangcong@gmail.com> writes:
>
>> Fix wrong /proc/kcore size on x86_64.
>>
>> x86_64 uses __va() macro to caculate the virtual address passed to kclist_add()
>> but decodes it with its own macro kc_vadd_to_offset(). This is wrong.
>
> Ok.  I finally understand what is going on here, and no kc_vaddr_to_offset
> is not wrong when applied to a virtual address.  In fact I expect the current
> definition makes things a bit more predictable.
>
> And yes kclist_add is must be given a virtual address
>
>> Also, according to Documentation/x86/x86_64/mm.txt, kc_vaddr_to_offset()
>> is wrong too.
>
> How so?  The file offset is a number space that is different from both
> physical and virtual addresses.

Why? They _do_ have some calculated relations.

>
>> So just remove them, use the generic macro.
>
> I think a case can be made either way.  In practice neither answer
> gives us a dense offset space on x86_64 so I think I prefer the
> current definition which sets or clears the high bits as opposed
> to something that mangles the address more.
>

I am trying to dig more... There must be something wrong there.

>
> It uses get_kcore_size and (size_t)high_memory - PAGE_OFFSET + PAGE_SIZE;
> The second definition being bogus as it has nothing to do with which
> offsets are accepted.

Agreed. Maybe we can just remove the second one and update the doc?