Re: [Patch BUGFIX] kcore: fix its wrong size on x86_64

Tao Ma
2009-06-15T08:35:35Z

Hi Amerigo,

The wrong number I mean is 131941393240064.

So do you think
[root@test3 ~]# ls -l /proc/kcore
-r-------- 1 root root 131941393240064 Jun 15 13:39 /proc/kcore

is better than

[taoma@test2 ~]$ ll /proc/kcore
-r-------- 1 root root 281474974617600 Jun 15 15:20 /proc/kcore
?

I don't think so.

Actually the right result should look like

[root@test8 ~]# ls -l /proc/kcore
-r-------- 1 root root 5301604352 Jun 15 13:35 /proc/kcore

And with your patch I can't get this number.

Regards,
Tao

Amerigo Wang wrote:
> On Mon, Jun 15, 2009 at 01:59:08PM +0800, Tao Ma wrote:
>> Hi Amerigo,
>> Just patched my kernel and tested.
>> The bad news is that although the number is changed, but it isn't right
>> either.
>
> Thanks for testing.
>
> What do you mean by saying it isn't right? You think it is wrong only because
> it is more than phy mem size?
>
> Again, the document of /proc/kcore is wrong, it _can_ be more than phy mem size.
>
> Regards.
>