From: "H. Peter Anvin" <hpa@zytor.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Petr Tesarik <ptesarik@suse.cz>,
LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH] x86: clean up vdso-layout.lds.S
Date: Fri, 05 Jun 2009 09:24:25 -0700 [thread overview]
Message-ID: <4A2946B9.3070701@zytor.com> (raw)
In-Reply-To: <20090605162738.GI1065@one.firstfloor.org>
Andi Kleen wrote:
>> Any comments on this? It doesn't change anything. It only makes it
>> harder to break vDSOs by accident (such as the latest buglet with TSC
>> synchronization).
>
> Looks ok to me. Although it would have been nicer if you hadn't mixed
> that many changes together.
>
> Acked-by: Andi Kleen <ak@linux.intel.com>
>
It would have. That makes review harder, and right at the moment time
is a bit at a premium. It looks like a good cleanup, but it also looks
like it's going to need some testing, which means that since it is not a
functional change I would feel best if we could put it on the .32 track
after the imminent merge window craziness is over.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2009-06-05 16:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-01 14:05 [PATCH] x86: clean up vdso-layout.lds.S Petr Tesarik
2009-06-05 15:25 ` Petr Tesarik
2009-06-05 16:27 ` Andi Kleen
2009-06-05 16:24 ` H. Peter Anvin [this message]
2009-06-09 7:32 ` Petr Tesarik
2009-06-05 20:07 ` Sam Ravnborg
2009-06-09 7:26 ` Petr Tesarik
2009-06-09 7:52 ` Roland McGrath
2009-06-09 7:57 ` Petr Tesarik
2009-06-09 8:09 ` Roland McGrath
2009-06-09 8:29 ` Petr Tesarik
2009-06-09 15:41 ` H. Peter Anvin
2009-06-09 18:11 ` Sam Ravnborg
2009-06-09 18:16 ` H. Peter Anvin
2009-06-09 19:22 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A2946B9.3070701@zytor.com \
--to=hpa@zytor.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=ptesarik@suse.cz \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox