From: Randy Dunlap <randy.dunlap@oracle.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
mirq-linux@rere.qmqm.pl, Pierre Ossman <pierre@ossman.eu>
Subject: [PATCH -next] mmc: cb710 cleanups
Date: Fri, 05 Jun 2009 11:03:05 -0700 [thread overview]
Message-ID: <4A295DD9.2050301@oracle.com> (raw)
In-Reply-To: <20090605164104.3cebe18d.sfr@canb.auug.org.au>
From: Randy Dunlap <randy.dunlap@oracle.com>
- don't define DEBUG, just use CONFIG_CB710_DEBUG or CONFIG_MMC_DEBUG
- fix printk format warnings
In file included from drivers/mmc/host/cb710-mmc.h:13,
from drivers/mmc/host/cb710-mmc.c:15:
include/linux/cb710.h:14:1: warning: "DEBUG" redefined
<command-line>: warning: this is the location of the previous definition
drivers/mmc/host/cb710-mmc.c:222: warning: format '%d' expects type 'int', but argument 4 has type 'size_t'
drivers/mmc/host/cb710-mmc.c:222: warning: format '%d' expects type 'int', but argument 6 has type 'size_t'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: mirq-linux@rere.qmqm.pl
Cc: Pierre Ossman <pierre@ossman.eu>
---
drivers/mmc/host/cb710-mmc.c | 2 +-
include/linux/cb710.h | 4 ----
2 files changed, 1 insertion(+), 5 deletions(-)
--- linux-next-20090605.orig/drivers/mmc/host/cb710-mmc.c
+++ linux-next-20090605/drivers/mmc/host/cb710-mmc.c
@@ -219,7 +219,7 @@ static void cb710_mmc_set_transfer_size(
cb710_write_port_32(slot, CB710_MMC_TRANSFER_SIZE_PORT,
((count - 1) << 16)|(blocksize - 1));
- dev_vdbg(cb710_slot_dev(slot), "set up for %d block%s of %d bytes\n",
+ dev_vdbg(cb710_slot_dev(slot), "set up for %zu block%s of %zu bytes\n",
count, count == 1 ? "" : "s", blocksize);
}
--- linux-next-20090605.orig/include/linux/cb710.h
+++ linux-next-20090605/include/linux/cb710.h
@@ -10,10 +10,6 @@
#ifndef LINUX_CB710_DRIVER_H
#define LINUX_CB710_DRIVER_H
-#ifdef CONFIG_CB710_DEBUG
-#define DEBUG
-#endif
-
/* verify assumptions on platform_device framework */
#define CONFIG_CB710_DEBUG_ASSUMPTIONS
--
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/
next prev parent reply other threads:[~2009-06-05 18:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-05 6:41 linux-next: Tree for June 5 Stephen Rothwell
2009-06-05 18:03 ` Randy Dunlap [this message]
2009-06-06 9:59 ` [PATCH -next] mmc: cb710 cleanups Michał Mirosław
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A295DD9.2050301@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=pierre@ossman.eu \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox