From: "H. Peter Anvin" <hpa@zytor.com>
To: Jaswinder Singh Rajput <jaswinder@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>, x86 maintainers <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -tip] x86: cpu/proc.c adding extended_cpuid_level for /proc/cpuinfo
Date: Fri, 05 Jun 2009 13:55:09 -0700 [thread overview]
Message-ID: <4A29862D.6030601@zytor.com> (raw)
In-Reply-To: <1244227115.2507.3.camel@ht.satnam>
Jaswinder Singh Rajput wrote:
> Hello Andrew,
>
> On Tue, 2009-05-12 at 23:21 -0700, Andrew Morton wrote:
>> On Tue, 12 May 2009 12:44:42 +0530 Jaswinder Singh Rajput <jaswinder@kernel.org> wrote:
>>
>>> + "ext cpuid level\t: 0x%x\n"
>> It's unobvious what "ext" means. External?
>>
>> Can we make it "extended cpuid level"?
>
> extended cpuid level will look like this :
>
> fpu : yes
> fpu_exception : yes
> cpuid level : 5
> wp : yes
> extended cpuid level: 0x80000008
> flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe constant_tsc pebs bts pni dtes64 monitor ds_cpl cid
>
The more I'm thinking about this I think it was a mistake to put cpuid
level: there in the first place, too. My opinion is increasingly to
leave this to x86info or other user-space tools.
-hpa
next prev parent reply other threads:[~2009-06-05 20:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-12 7:14 [PATCH -tip] x86: cpu/proc.c adding extended_cpuid_level for /proc/cpuinfo Jaswinder Singh Rajput
2009-05-12 13:39 ` Borislav Petkov
2009-05-12 13:49 ` Jaswinder Singh Rajput
2009-05-12 14:10 ` Borislav Petkov
2009-05-12 16:40 ` H. Peter Anvin
2009-05-12 18:13 ` Borislav Petkov
2009-05-12 18:47 ` H. Peter Anvin
2009-05-12 19:49 ` Borislav Petkov
2009-06-05 19:20 ` Jaswinder Singh Rajput
2009-05-13 6:21 ` Andrew Morton
2009-05-13 8:03 ` Andi Kleen
2009-06-05 18:38 ` Jaswinder Singh Rajput
2009-06-05 20:55 ` H. Peter Anvin [this message]
2009-06-06 4:23 ` Jaswinder Singh Rajput
2009-06-10 16:40 ` Jaswinder Singh Rajput
2009-06-10 17:14 ` H. Peter Anvin
2009-06-10 17:42 ` Borislav Petkov
2009-06-10 17:48 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A29862D.6030601@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=jaswinder@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox