From: Avi Kivity <avi@redhat.com>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: guillaume.thouvenin@ext.bull.net, linux-kernel@vger.kernel.org
Subject: Re: [2.6.30-rc8 KVM] gcc 3.3 dies at emulate_2op_cl().
Date: Sun, 07 Jun 2009 11:29:45 +0300 [thread overview]
Message-ID: <4A2B7A79.4060600@redhat.com> (raw)
In-Reply-To: <200906071638.CIC52145.OFOQHLFSMOJVFt@I-love.SAKURA.ne.jp>
[-- Attachment #1: Type: text/plain, Size: 385 bytes --]
Tetsuo Handa wrote:
> Avi Kivity wrote:
>
>>> I think something is wrong with emulate_2op_cl() when compiled with gcc 3.3.5 .
>>>
>> This is on i386, not x86_64, yes?
>>
>>
> Yes. Building "make allmodconfig" using Debian Sarge on i686 machine.
>
Does the attached patch help?
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
[-- Attachment #2: fix-gcc3.3-register-pressure.patch --]
[-- Type: text/plain, Size: 509 bytes --]
diff --git a/arch/x86/kvm/x86_emulate.c b/arch/x86/kvm/x86_emulate.c
index 22c765d..01717a5 100644
--- a/arch/x86/kvm/x86_emulate.c
+++ b/arch/x86/kvm/x86_emulate.c
@@ -451,7 +451,7 @@ static u32 group2_table[] = {
_PRE_EFLAGS("0", "5", "2") \
_op _suffix " %4,%1 \n" \
_POST_EFLAGS("0", "5", "2") \
- : "=m" (_eflags), "+r" (_dstv), "=&r" (_tmp) \
+ : "=m" (_eflags), "+rm" (_dstv), "=&r" (_tmp) \
: "c" (_clv) , "r" (_srcv), "i" (EFLAGS_MASK) \
); \
\
next prev parent reply other threads:[~2009-06-07 8:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-05 5:39 [2.6.30-rc8 KVM] gcc 3.3 dies at emulate_2op_cl() Tetsuo Handa
2009-06-07 6:24 ` Avi Kivity
2009-06-07 7:38 ` Tetsuo Handa
2009-06-07 8:29 ` Avi Kivity [this message]
2009-06-07 8:47 ` Tetsuo Handa
2009-06-07 9:01 ` Avi Kivity
2009-06-07 9:39 ` Tetsuo Handa
2009-06-07 9:40 ` Avi Kivity
2009-06-07 10:00 ` Tetsuo Handa
2009-06-07 10:03 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A2B7A79.4060600@redhat.com \
--to=avi@redhat.com \
--cc=guillaume.thouvenin@ext.bull.net \
--cc=linux-kernel@vger.kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox