From: Jiri Slaby <jirislaby@gmail.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org, jeffrey.mitchell@gmail.com
Subject: Re: [PATCH] dmi: sanity check BIOS tables
Date: Sun, 07 Jun 2009 10:57:29 +0200 [thread overview]
Message-ID: <4A2B80F9.9070103@gmail.com> (raw)
In-Reply-To: <20090606230137.17029.51286.stgit@t61.ukuu.org.uk>
On 06/07/2009 01:01 AM, Alan Cox wrote:
> @@ -260,6 +276,11 @@ static void __init dmi_save_ipmi_device(const struct dmi_header *dm)
> struct dmi_device *dev;
> void * data;
>
> + if (((u8 *)dm) + dm->length > dmi_end) {
I think this should be >= too.
> + printk(KERN_ERR "dmi_save_ipmi_device: table overrun.\n");
> + return;
> + }
> +
next prev parent reply other threads:[~2009-06-07 8:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-06 23:01 [PATCH] dmi: sanity check BIOS tables Alan Cox
2009-06-07 8:57 ` Jiri Slaby [this message]
2009-06-07 13:56 ` Jeff Mitchell
2009-06-07 19:08 ` Jiri Slaby
2009-06-08 2:08 ` Jeff Mitchell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A2B80F9.9070103@gmail.com \
--to=jirislaby@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jeffrey.mitchell@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox