From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754299AbZFGJlG (ORCPT ); Sun, 7 Jun 2009 05:41:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753270AbZFGJk5 (ORCPT ); Sun, 7 Jun 2009 05:40:57 -0400 Received: from mx2.redhat.com ([66.187.237.31]:36869 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753016AbZFGJk4 (ORCPT ); Sun, 7 Jun 2009 05:40:56 -0400 Message-ID: <4A2B8B22.3020602@redhat.com> Date: Sun, 07 Jun 2009 12:40:50 +0300 From: Avi Kivity User-Agent: Thunderbird 2.0.0.21 (X11/20090320) MIME-Version: 1.0 To: Tetsuo Handa CC: guillaume.thouvenin@ext.bull.net, linux-kernel@vger.kernel.org Subject: Re: [2.6.30-rc8 KVM] gcc 3.3 dies at emulate_2op_cl(). References: <4A2B5D0E.20002@redhat.com> <200906071638.CIC52145.OFOQHLFSMOJVFt@I-love.SAKURA.ne.jp> <4A2B7A79.4060600@redhat.com> <200906071747.FFJ57396.MSOOQFVHtFOJLF@I-love.SAKURA.ne.jp> <4A2B8201.8050904@redhat.com> <200906071839.DFB51529.JFHLOFtMFOSVQO@I-love.SAKURA.ne.jp> In-Reply-To: <200906071839.DFB51529.JFHLOFtMFOSVQO@I-love.SAKURA.ne.jp> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tetsuo Handa wrote: > Avi Kivity wrote: > >> What if you change "rm" in the patch to "m"? >> > It still fails. > > __asm__ __volatile__ ( \ > _PRE_EFLAGS("0", "5", "2") \ > _op _suffix " %4,%1 \n" \ > _POST_EFLAGS("0", "5", "2") \ > : "=m" (_eflags), "+m" (_dstv), "=&r" (_tmp) \ > : "c" (_clv) , "r" (_srcv), "i" (EFLAGS_MASK) \ > ); > I can eliminate _tmp by using lahf/sahf, but it's not going to be a trivial patch. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.