From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Pranith Kumar <pranith.hacks@gmail.com>
Cc: greg@kroah.com, linux-kernel@vger.kernel.org
Subject: Re: [TRIVIAL][PATCH 1/1] Fix warning in staging/otus/ioctl.c
Date: Mon, 08 Jun 2009 11:09:52 +0200 [thread overview]
Message-ID: <4A2CD560.8070002@s5r6.in-berlin.de> (raw)
In-Reply-To: <4A2CC6FA.6020904@gmail.com>
Pranith Kumar wrote:
> @@ -629,7 +629,7 @@ void update_os_packet_info(
> pOSPkt->dev = get_netdev_from_bssid(pAd, FromWhichBSSID);
> pOSPkt->data = pRxBlk->pData;
> pOSPkt->len = pRxBlk->DataSize;
> - pOSPkt->tail = pOSPkt->data + pOSPkt->len;
> + pOSPkt->tail = (UCHAR *) (pOSPkt->data + pOSPkt->len);
> }
>
>
This is what I meant with "a warning should stay there as long as the
underlying problem isn't fixed".
This code uses defined types which are foreign to Linux. We don't
define UCHAR in Linux. /This/ needs to be fixed in the entire driver.
Until this is not done, there is no reason to add this pointer type cast
merely to quieten gcc.
--
Stefan Richter
-=====-==--= -==- -=---
http://arcgraph.de/sr/
next prev parent reply other threads:[~2009-06-08 9:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-08 7:19 [TRIVIAL][PATCH 1/1] Fix warning in staging/otus/ioctl.c Pranith Kumar
2009-06-08 8:08 ` Pranith Kumar
2009-06-08 9:09 ` Stefan Richter [this message]
2009-06-08 10:02 ` Pranith Kumar
2009-06-08 18:01 ` Stefan Richter
2009-06-08 18:18 ` Stefan Richter
-- strict thread matches above, loose matches on Subject: below --
2009-05-29 7:54 Pranith Kumar
2009-06-02 21:47 ` Greg KH
2009-06-03 6:49 ` Pranith Kumar
2009-06-03 15:21 ` Greg KH
2009-06-04 5:53 ` Pranith Kumar
2009-06-04 17:56 ` Greg KH
2009-06-05 5:10 ` Pranith Kumar
2009-06-05 6:15 ` Pranith Kumar
2009-06-04 18:37 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A2CD560.8070002@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pranith.hacks@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox