Re: 2.6.30-rc8 Oops whilst booting

Chris Clayton
2009-06-08T19:17:57Z

Linus,

2009/6/8 Linus Torvalds <torvalds@linux-foundation.org>:
>
>
> On Mon, 8 Jun 2009, Chris Clayton wrote:
>>
>> I can confirm that a kernel built with Jaswinder's patch applied
>> survived 200 boots without a panic.
>
> Ok, goodie.
>
> Can you confirm that the further cleanup (removing the pointless 'ret'
> variable and the useless empty checking around 'for_each_entry') also
> works for you?
>
>                Linus
>
> ---
>  kernel/async.c |   15 +++++----------
>  1 files changed, 5 insertions(+), 10 deletions(-)
>
> diff --git a/kernel/async.c b/kernel/async.c
> index 5054030..27235f5 100644
> --- a/kernel/async.c
> +++ b/kernel/async.c
> @@ -92,23 +92,18 @@ extern int initcall_debug;
>  static async_cookie_t  __lowest_in_progress(struct list_head *running)
>  {
>        struct async_entry *entry;
> -       async_cookie_t ret = next_cookie; /* begin with "infinity" value */
>
>        if (!list_empty(running)) {
>                entry = list_first_entry(running,
>                        struct async_entry, list);
> -               ret = entry->cookie;
> +               return entry->cookie;
>        }
>
> -       if (!list_empty(&async_pending)) {
> -               list_for_each_entry(entry, &async_pending, list)
> -                       if (entry->running == running) {
> -                               ret = entry->cookie;
> -                               break;
> -                       }
> -       }
> +       list_for_each_entry(entry, &async_pending, list)
> +               if (entry->running == running)
> +                       return entry->cookie;
>
> -       return ret;
> +       return next_cookie;     /* "infinity" value */
>  }
>
>  static async_cookie_t  lowest_in_progress(struct list_head *running)
>

Yes, rc8-git5 with your patch applied has booted 100 times without a panic.

May I add that the people who thought of, designed and implemented
kexec should have a large and shiny medals pinned to their chests.
Well over 1000 kernel boots have been executed on my PC today and, if
I hadn't been able to do that automatically with a few lines of script
at the head of /etc/rc.d/rc.local, I would have been bleary-eyed
before noon :-)

Chris

--
No, Sir; there is nothing which has yet been contrived by man, by
which so much happiness is produced as by a good tavern or inn -
Doctor Samuel Johnson