From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755691AbZFJB11 (ORCPT ); Tue, 9 Jun 2009 21:27:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754348AbZFJB1T (ORCPT ); Tue, 9 Jun 2009 21:27:19 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:56109 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751181AbZFJB1S (ORCPT ); Tue, 9 Jun 2009 21:27:18 -0400 Message-ID: <4A2F0C4A.8020109@cn.fujitsu.com> Date: Wed, 10 Jun 2009 09:28:42 +0800 From: Li Zefan User-Agent: Thunderbird 2.0.0.9 (X11/20071115) MIME-Version: 1.0 To: Ingo Molnar CC: Steven Rostedt , linux-kernel@vger.kernel.org, Andrew Morton , Frederic Weisbecker Subject: Re: [PATCH 0/2] [GIT PULL] tracing/events/ring-buffer: block trace points and fix References: <20090609163657.557589106@goodmis.org> <20090609234655.GA24118@elte.hu> In-Reply-To: <20090609234655.GA24118@elte.hu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ingo Molnar wrote: > * Steven Rostedt wrote: > >> Ingo, >> >> Please pull the latest tip/tracing/ftrace tree, which can be found at: >> >> git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-2.6-trace.git >> tip/tracing/ftrace >> >> >> Li Zefan (1): >> tracing/events: convert block trace points to TRACE_EVENT() >> >> Steven Rostedt (1): >> ring-buffer: fix ret in rb_add_time_stamp >> >> ---- >> block/blk-core.c | 16 +- >> block/elevator.c | 8 +- >> drivers/md/dm.c | 5 +- >> fs/bio.c | 3 +- >> include/linux/blktrace_api.h | 13 ++ >> include/trace/block.h | 76 ------- >> include/trace/events/block.h | 483 ++++++++++++++++++++++++++++++++++++++++++ >> kernel/trace/Makefile | 5 +- >> kernel/trace/blktrace.c | 78 +++++++- >> kernel/trace/ring_buffer.c | 2 +- >> mm/bounce.c | 5 +- >> 11 files changed, 589 insertions(+), 105 deletions(-) > > I'm getting some build failures here: > > In file included from mm/highmem.c:30: > include/linux/blktrace_api.h:223: warning: ‘struct request’ declared inside parameter list > include/linux/blktrace_api.h:223: warning: its scope is only this definition or declaration, which is probably not what you want > include/linux/blktrace_api.h: In function ‘blk_cmd_buf_len’: > include/linux/blktrace_api.h:225: error: implicit declaration of function ‘blk_pc_request’ > include/linux/blktrace_api.h:225: error: dereferencing pointer to incomplete type > include/linux/blktrace_api.h: At top level: > include/linux/blktrace_api.h:228: warning: ‘struct request’ declared inside parameter list > include/linux/blktrace_api.h:230: warning: ‘struct request’ declared inside parameter list > distcc[15629] ERROR: compile mm/highmem.c on a/32 failed > I've fixed it. I'll post a new version after I've done some more building tests.