public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Ungerer <gerg@snapgear.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: linux-kernel@vger.kernel.org,
	uclinux-dist-devel@blackfin.uclinux.org, uclinux-dev@uclinux.org,
	linux-mtd@lists.infradead.org
Subject: Re: [PATCH 2/3] mtd/maps: uclinux: mark local stuff static
Date: Wed, 10 Jun 2009 11:47:30 +1000	[thread overview]
Message-ID: <4A2F10B2.7000003@snapgear.com> (raw)
In-Reply-To: <1243380798-10089-2-git-send-email-vapier@gentoo.org>


Mike Frysinger wrote:
> The uclinux_ram_mtdinfo, uclinux_romfs, and uclinux_point symbols do not
> need to be visible outside of this module, so mark them static.
> 
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> CC: Greg Ungerer <gerg@uclinux.org>

Acked-by: Greg Ungerer <gerg@uclinux.org>


> CC: uclinux-dev@uclinux.org
> CC: linux-mtd@lists.infradead.org
> ---
>  drivers/mtd/maps/uclinux.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/mtd/maps/uclinux.c b/drivers/mtd/maps/uclinux.c
> index 61d4087..d4314fb 100644
> --- a/drivers/mtd/maps/uclinux.c
> +++ b/drivers/mtd/maps/uclinux.c
> @@ -30,11 +30,11 @@ struct map_info uclinux_ram_map = {
>  	.size = 0,
>  };
>  
> -struct mtd_info *uclinux_ram_mtdinfo;
> +static struct mtd_info *uclinux_ram_mtdinfo;
>  
>  /****************************************************************************/
>  
> -struct mtd_partition uclinux_romfs[] = {
> +static struct mtd_partition uclinux_romfs[] = {
>  	{ .name = "ROMfs" }
>  };
>  
> @@ -42,7 +42,7 @@ struct mtd_partition uclinux_romfs[] = {
>  
>  /****************************************************************************/
>  
> -int uclinux_point(struct mtd_info *mtd, loff_t from, size_t len,
> +static int uclinux_point(struct mtd_info *mtd, loff_t from, size_t len,
>  	size_t *retlen, void **virt, resource_size_t *phys)
>  {
>  	struct map_info *map = mtd->priv;

-- 
------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg@snapgear.com
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
825 Stanley St,                             FAX:         +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia         WEB: http://www.SnapGear.com

  reply	other threads:[~2009-06-10  1:47 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-26  9:46 [PATCH 1/2] mtd/maps: uclinux: fix building when partition support is disabled Mike Frysinger
2009-05-26  9:46 ` [PATCH 2/2] mtd/maps: uclinux: support Blackfin systems Mike Frysinger
2009-05-26 11:31   ` Paul Mundt
2009-05-26 16:42     ` Mike Frysinger
2009-05-26 16:47       ` Paul Mundt
2009-05-26 16:50         ` Mike Frysinger
2009-05-26 17:06           ` Paul Mundt
2009-05-26 17:24             ` Mike Frysinger
2009-05-26 23:19               ` Paul Mundt
2009-05-26 23:22                 ` Mike Frysinger
2009-05-26 23:27                 ` [uClinux-dev] " David McCullough
2009-05-26 23:33                 ` [PATCH 1/3] mtd/maps: uclinux: allow systems to override map addr/size Mike Frysinger
2009-05-26 23:40                   ` Paul Mundt
2009-05-26 23:46                   ` Paul Mundt
2009-05-27  0:46                     ` Mike Frysinger
2009-05-27  1:03                       ` Paul Mundt
2009-05-28 15:26                   ` Artem Bityutskiy
2009-05-26 23:33                 ` [PATCH 2/3] mtd/maps: uclinux: mark local stuff static Mike Frysinger
2009-06-10  1:47                   ` Greg Ungerer [this message]
2009-05-26 23:33                 ` [PATCH 3/3] mtd/maps: uclinux: do not allow to be built as a module Mike Frysinger
2009-06-10  2:34                   ` [uClinux-dev] " Greg Ungerer
2009-06-10  1:46 ` [uClinux-dev] [PATCH 1/2] mtd/maps: uclinux: fix building when partition support is disabled Greg Ungerer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A2F10B2.7000003@snapgear.com \
    --to=gerg@snapgear.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=uclinux-dev@uclinux.org \
    --cc=uclinux-dist-devel@blackfin.uclinux.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox