From: matthieu castet <castet.matthieu@free.fr>
To: Wim Van Sebroeck <wim@iguana.be>
Cc: Florian Fainelli <florian@openwrt.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mips@linux-mips.org,
biblbroks@sezampro.rs
Subject: Re: add bcm47xx watchdog driver
Date: Wed, 10 Jun 2009 20:47:54 +0200 [thread overview]
Message-ID: <4A2FFFDA.6010807@free.fr> (raw)
In-Reply-To: <20090610171732.GI16090@infomag.iguana.be>
Hi,
Wim Van Sebroeck wrote:
> Hi Matthieu, Florian,
>
>> It works very well on my Netgear WGT634U, thanks !
>>
>> Tested-by: Florian Fainelli <florian@openwrt.org>
>
> I incorporated the changes of Andrew and did a clean-up here and there to keep checkpatch happy.
> Could you test the attached diff to see that it still works.
>
> Thanks,
> Wim.
>
> +
> +#define WDT_DEFAULT_TIME 30 /* seconds */
> +#define WDT_MAX_TIME 255 /* seconds */
Why have changed this from 256 to 255 ?
> +}
> +
> +static int bcm47xx_wdt_notify_sys(struct notifier_block *this,
> + nsigned long code, void *unused)
^^^^
Does this build ?
Matthieu
next prev parent reply other threads:[~2009-06-10 18:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-04 20:24 add bcm47xx watchdog driver matthieu castet
2009-06-05 13:58 ` Florian Fainelli
2009-06-05 14:58 ` castet.matthieu
2009-06-06 10:58 ` Florian Fainelli
2009-06-05 16:57 ` add bcm47xx watchdog driver v2 matthieu castet
2009-06-05 19:48 ` add bcm47xx watchdog driver Andrew Morton
2009-06-05 20:30 ` matthieu castet
2009-06-08 14:15 ` Florian Fainelli
2009-06-10 17:17 ` Wim Van Sebroeck
2009-06-10 18:47 ` matthieu castet [this message]
2009-06-10 19:06 ` Wim Van Sebroeck
2009-06-05 19:50 ` Andrew Morton
2009-06-05 20:03 ` matthieu castet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A2FFFDA.6010807@free.fr \
--to=castet.matthieu@free.fr \
--cc=akpm@linux-foundation.org \
--cc=biblbroks@sezampro.rs \
--cc=florian@openwrt.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox