From: Amerigo Wang <amwang@redhat.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Alexey Dobriyan <adobriyan@gmail.com>
Subject: Re: 2.6.31 -mm merge plans
Date: Thu, 11 Jun 2009 13:25:43 +0800 [thread overview]
Message-ID: <4A309557.8040508@redhat.com> (raw)
In-Reply-To: <20090611031005.GU8633@ZenIV.linux.org.uk>
Al Viro wrote:
> On Thu, Jun 11, 2009 at 09:15:05AM +0800, Amerigo Wang wrote:
>
>> Hi, Al.
>>
>> Just as what I said in the description of that patch, one only has
>> extern functions that are _only_ used in another as function pointers.
>>
>
> Er... So what? Amount of functions made static is not, per se, a
> useful metrics of anything.
>
Not only about static, but also because they are used via function pointers.
Logically, it is better for these functions used via pointers to be kept in
the same file with the struct which holds these function pointers.
next prev parent reply other threads:[~2009-06-11 5:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-10 18:51 2.6.31 -mm merge plans Andrew Morton
2009-06-10 19:00 ` mac80211-use-kzfree-in-key-handling-to-enforce-data-sanitization (was Re: 2.6.31 -mm merge plans) John W. Linville
2009-06-10 19:08 ` 2.6.31 -mm merge plans Al Viro
2009-06-10 19:16 ` Andrew Morton
2009-06-11 1:15 ` Amerigo Wang
2009-06-11 3:10 ` Al Viro
2009-06-11 5:25 ` Amerigo Wang [this message]
2009-06-13 20:53 ` Eric W. Biederman
2009-06-11 2:23 ` KOSAKI Motohiro
2009-06-11 11:40 ` mmc_spi-use-eilseq-for-possible-transmission-errors.patch (was Re: 2.6.31 -mm merge plans) Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A309557.8040508@redhat.com \
--to=amwang@redhat.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox