From: Li Zefan <lizf@cn.fujitsu.com>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu,
torvalds@linux-foundation.org, yinghai@kernel.org
Subject: Re: [PATCH 2/2] sched: use slab in cpupri_init()
Date: Thu, 11 Jun 2009 15:37:06 +0800 [thread overview]
Message-ID: <4A30B422.8080109@cn.fujitsu.com> (raw)
In-Reply-To: <1244705062.17483.9.camel@penberg-laptop>
Pekka Enberg wrote:
> Hi Li!
>
> On Thu, 2009-06-11 at 14:10 +0800, Li Zefan wrote:
>>> @@ -163,9 +167,7 @@ int __init_refok cpupri_init(struct cpupri *cp, bool bootmem)
>> so the __init_refok tag can be removed, no?
>
> I am not sure how this is related to my patch but as long as
> init_rootdomain() has it, cpupri_init() should too AFAICT.
>
cpupri_init() is marked as __init_refok, because it calls
alloc_bootmem_cpumask_var() not because init_rootdomain()
has the tag. Now this patch removes this function call,
so the tag is no long needed.
>
>>>
>>> spin_lock_init(&vec->lock);
>>> vec->count = 0;
>>> - if (bootmem)
>>> - alloc_bootmem_cpumask_var(&vec->mask);
>>> - else if (!zalloc_cpumask_var(&vec->mask, GFP_KERNEL))
>>> + if (!zalloc_cpumask_var(&vec->mask, gfp))
>>> goto cleanup;
>>> }
>>>
>
next prev parent reply other threads:[~2009-06-11 7:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-11 5:46 [PATCH 2/2] sched: use slab in cpupri_init() Pekka J Enberg
2009-06-11 6:10 ` Li Zefan
2009-06-11 7:24 ` Pekka Enberg
2009-06-11 7:37 ` Li Zefan [this message]
2009-06-11 7:37 ` Pekka Enberg
2009-06-11 7:50 ` Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A30B422.8080109@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=penberg@cs.helsinki.fi \
--cc=torvalds@linux-foundation.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox