Re: Kernel 2.6.30: Memory/XFS leak, OOM killer kills many processes

Felix Blyakher
2009-06-12T15:55:00Z

On Jun 12, 2009, at 3:37 AM, Justin Piszcz wrote:

>
>
> On Thu, 11 Jun 2009, Felix Blyakher wrote:
>
>>
>> On Jun 11, 2009, at 12:31 PM, Eric Sandeen wrote:
>>
>>> Justin Piszcz wrote:
>>>> On Thu, 11 Jun 2009, Justin Piszcz wrote:
>> The following should fix it:
>>
>> diff --git a/fs/xfs/xfs_bmap.c b/fs/xfs/xfs_bmap.c
>> index 4b0f6ef..7928b99 100644
>> --- a/fs/xfs/xfs_bmap.c
>> +++ b/fs/xfs/xfs_bmap.c
>> @@ -6086,6 +6086,7 @@ xfs_getbmap(
>> break;
>> }
>>
>> + kmem_free(out);
>> return error;
>> }
>>
>>
>> Felix
>
> Just FYI if anyone tries to run the patch it will not work:
>
> # patch -p1 < ../xfs.patch patching file fs/xfs/xfs_bmap.c
> patch: **** malformed patch at line 11: }

Must have been copy-and-paste problem. The real one is good :)

> So just goto line ~6086 and add the kmem_free(out); above the return
> error.
>
> Status:
> This patch fixes the problem, thanks!

Thanks for reporting and verifying the fix!
It's ready now for the linux-next in the official xfs repo,
going upstream with the pull request later today and then be
ready for inclusion in 2.6.30.

Felix

>
>
> Justin.
>