From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764021AbZFLCK3 (ORCPT ); Thu, 11 Jun 2009 22:10:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756308AbZFLCKT (ORCPT ); Thu, 11 Jun 2009 22:10:19 -0400 Received: from hera.kernel.org ([140.211.167.34]:40540 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755960AbZFLCKS (ORCPT ); Thu, 11 Jun 2009 22:10:18 -0400 Message-ID: <4A31B8BF.30304@kernel.org> Date: Fri, 12 Jun 2009 11:09:03 +0900 From: Tejun Heo User-Agent: Thunderbird 2.0.0.19 (X11/20081227) MIME-Version: 1.0 To: Christoph Lameter CC: linux-kernel@vger.kernel.org, David Howells , Ingo Molnar , Rusty Russell , Eric Dumazet , davem@davemloft.net Subject: Re: [this_cpu_xx 01/11] Introduce this_cpu_ptr() and generic this_cpu_* operations References: <20090605191819.376530498@gentwo.org> <20090605191850.441840884@gentwo.org> <4A2F40A3.5020602@kernel.org> In-Reply-To: X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0 (hera.kernel.org [127.0.0.1]); Fri, 12 Jun 2009 02:09:06 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Christoph Lameter wrote: > On Wed, 10 Jun 2009, Tejun Heo wrote: > >> Looks good to me. The only qualm I have is that I wish these macros >> take pointer instead of the symbol name directly. Currently it's not > > They take the adress of the scalar. No symbol name is involved. > >> possible due to the per_cpu__ appending thing but those should go with >> Rusty's patches and the same ops should be useable for both static and >> dynamic ones. One problem which may occur with such scheme is when > > They are usable for both as the following patches show. Oops, sorry about that. Got confused there. :-) Thanks. -- tejun