From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755638AbZFLPVZ (ORCPT ); Fri, 12 Jun 2009 11:21:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751582AbZFLPVS (ORCPT ); Fri, 12 Jun 2009 11:21:18 -0400 Received: from courier.cs.helsinki.fi ([128.214.9.1]:46716 "EHLO mail.cs.helsinki.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750744AbZFLPVS (ORCPT ); Fri, 12 Jun 2009 11:21:18 -0400 Message-ID: <4A327161.7000803@cs.helsinki.fi> Date: Fri, 12 Jun 2009 18:16:49 +0300 From: Pekka Enberg User-Agent: Thunderbird 2.0.0.21 (Macintosh/20090302) MIME-Version: 1.0 To: Linus Torvalds CC: Nick Piggin , Ingo Molnar , linux-mm@kvack.org, linux-kernel@vger.kernel.org, benh@kernel.crashing.org, akpm@linux-foundation.org, cl@linux-foundation.org Subject: Re: [PATCH v2] slab,slub: ignore __GFP_WAIT if we're booting or suspending References: <20090612091002.GA32052@elte.hu> <84144f020906120249y20c32d47y5615a32b3c9950df@mail.gmail.com> <20090612100756.GA25185@elte.hu> <84144f020906120311x7c7dd628s82e3ca9a840f9890@mail.gmail.com> <20090612101511.GC13607@wotan.suse.de> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Linus Torvalds wrote: > > On Fri, 12 Jun 2009, Pekka J Enberg wrote: >> Hmm. This is turning into one epic patch discussion for sure! But here's a >> patch to do what you suggested. With the amount of patches I am >> generating, I'm bound to hit the right one sooner or later, no?-) > > Ok, this one looks pretty good. I like the statics, and I like how it lets > each allocator decide what to do. > > Small nit: your mm/slab.c patch does an obviously unnecessary mask in: > > cache_alloc_debugcheck_before(cachep, flags & slab_gfp_flags); > > but that's stupid, because the bits were already masked earlier. Yeah, the SLAB parts were completely untested. I have this in my tree now (that I sent a pull request for): http://git.kernel.org/?p=linux/kernel/git/penberg/slab-2.6.git;a=commitdiff;h=f6b726dae91cc74fb3a00f192932ec4fe0949875 Do you want me to drop it? I can also do an incremental patch to do the unmasking as in this patch. Pekka