Re: [PATCH] mfd/da903x: initialize PMIC core early

[Mike Rapoport <mike@compulab.co.il>]

Samuel Ortiz wrote:
> Hi Mike,
> 
> On Mon, Jun 15, 2009 at 03:02:09PM +0300, Mike Rapoport wrote:
>> Samuel,
>> It'd be great if this can go to 2.6.31
> Sure. Care to explain why this needs to be called earlier ?

We want to have da903x regulators available early during boot, and since they
are subdevices of mfd/da903x they cannot be enabled until the da903x core is
initialized.
I just saw Liam Girdwood pull request with "regulator: Move regulator drivers to
subsys_initcall()" commit and jumped in :)


> Cheers,
> Samuel.
> 
>> Signed-off-by: Mike Rapoport <mike@compulab.co.il>
>> ---
>>  drivers/mfd/da903x.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/mfd/da903x.c b/drivers/mfd/da903x.c
>> index 7283d88..e5ffe56 100644
>> --- a/drivers/mfd/da903x.c
>> +++ b/drivers/mfd/da903x.c
>> @@ -561,7 +561,7 @@ static int __init da903x_init(void)
>>  {
>>  	return i2c_add_driver(&da903x_driver);
>>  }
>> -module_init(da903x_init);
>> +subsys_initcall(da903x_init);
>>
>>  static void __exit da903x_exit(void)
>>  {
>> -- 
>> 1.6.0.6
>>
>>
>> -- 
>> Sincerely yours,
>> Mike.
>>
> 

-- 
Sincerely yours,
Mike.