Re: [PATCH 1/6] Unified AVR32/AT91 MCI Driver

Rob Emanuele
2009-06-15T17:46:37Z

Hi Nicolas,

> First of all thank you for this splitting effort. It is definitively the
> good way of presenting things and ease reading a lot.

My pleasure.

>> ---
>>  drivers/mmc/host/Kconfig     |   16 ++++++++++++----
>>  drivers/mmc/host/atmel-mci.c |   33 +++++++++++++++++++++++++++++----
>>  2 files changed, 41 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
>> index b4cf691..6e2f52b 100644
>> --- a/drivers/mmc/host/Kconfig
>> +++ b/drivers/mmc/host/Kconfig
>> @@ -124,6 +124,12 @@ config MMC_AU1X
>>
>>         If unsure, say N.
>>
>> +choice
>> +     prompt "Atmel MMC Driver"
>> +     default MMC_ATMELMCI
>> +     help
>> +       Choose which driver to use for the Atmel MCI Silicon
>
> I suggest :
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index b4cf691..e779049 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -124,6 +124,12 @@ config MMC_AU1X
>
>          If unsure, say N.
>
> +choice
> +       prompt "Atmel SD/MMC Driver"
> +       default MMC_ATMELMCI if AVR32
> +       help
> +         Choose which driver to use for the Atmel MCI Silicon
> +
>  config MMC_AT91
>        tristate "AT91 SD/MMC Card Interface support"
>        depends on ARCH_AT91
>
> It will keep present default configuration for both AVR32 and AT91.
>

Fine with me.

>> diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c
>> index cf6a100..497dd51 100644
>> --- a/drivers/mmc/host/atmel-mci.c
>> +++ b/drivers/mmc/host/atmel-mci.c
>> @@ -2,11 +2,13 @@
>>   * Atmel MultiMedia Card Interface driver
>>   *
>>   * Copyright (C) 2004-2008 Atmel Corporation
>> + * Copyright (C) 2009 Rob Emanuele
>
> I think you can add your copyright on a file that you create or copy and
> modify from another file.

Noted for future reference. I wasn't sure what the ettiquete was.
Just wanted to make sure that if there were questions about the
changes I introduced people could find me. Now that I know more about
the maintaining process I see that is unnecessary.

>>
>> -#define ATMCI_DATA_ERROR_FLAGS       (MCI_DCRCE | MCI_DTOE | MCI_OVRE | MCI_UNRE)
>> +#define ATMCI_DATA_ERROR_FLAGS       (MCI_RINDE | MCI_RDIRE | MCI_RCRCE  \
>> +                              | MCI_RENDE | MCI_RTOE | MCI_DCRCE \
>> +                              | MCI_DTOE | MCI_OVRE | MCI_UNRE)
>
> We will have to consider what Haavard said: some are not data errors.
> But indeed, if you experienced errors not beeing addressed, we have to
> deal with them.
>

We'll have to keep looking into this. Would someone on the AVR side
be able to evaluate the effects of this on their platform?

I appreciate your time looking this over. Will you need me to further
revise this patch or will you incorporate the parts that your
comfortable with?

Thank you,

Rob Emanuele