From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Rob Emanuele <poorarm@shoreis.com>
Cc: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>,
Andrew Victor <avictor.za@gmail.com>,
linux-arm-kernel@lists.arm.linux.org.uk,
linux-kernel@vger.kernel.org, drzeus-mmc@drzeus.cx
Subject: Re: [PATCH 2/6] Unified AVR32/AT91 MCI Platform Driver
Date: Mon, 15 Jun 2009 18:35:22 +0200 [thread overview]
Message-ID: <4A36784A.1000109@atmel.com> (raw)
In-Reply-To: <c8284b5b0906121759o4057deb6kf59f818fa759ce57@mail.gmail.com>
Hi again,
Rob Emanuele :
> +
> + for (i = 0; i < ATMEL_MCI_MAX_NR_SLOTS; i++) {
> + if (data->slot[i].bus_width) {
> + /* input/irq */
> + if (data->slot[i].detect_pin) {
> +
> at91_set_gpio_input(data->slot[i].detect_pin, 1);
> + at91_set_deglitch(data->slot[i].detect_pin, 1);
> + }
> + if (data->slot[i].wp_pin)
There is some indentation errors in this patch (blank instead of tabs).
Best regards,
--
Nicolas Ferre
prev parent reply other threads:[~2009-06-15 16:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-13 0:59 [PATCH 2/6] Unified AVR32/AT91 MCI Platform Driver Rob Emanuele
2009-06-15 15:59 ` Nicolas Ferre
2009-06-15 18:04 ` Rob Emanuele
2009-06-15 16:35 ` Nicolas Ferre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A36784A.1000109@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=avictor.za@gmail.com \
--cc=drzeus-mmc@drzeus.cx \
--cc=haavard.skinnemoen@atmel.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=poorarm@shoreis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox