From: Rui Santos <rsantos@grupopie.com>
To: Wim Van Sebroeck <wim@iguana.be>
Cc: Stephen Clark <sclark46@earthlink.net>,
Denys Fedoryschenko <denys@visp.net.lb>,
Johannes Dewender <arch@jonnyjd.net>,
"Rafael J. Wysocki" <rjw@sisk.pl>, Frans Pop <elendil@planet.nl>,
Rutger Nijlunsing <bugzilla.kernel@tux.tmfweb.nl>,
Kernel Testers List <kernel-testers@vger.kernel.org>,
Andriy Gapon <avg@icyb.net.ua>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [WATCHDOG] iTCO_wdt.c - ICH9 reboot issue - testing wanted
Date: Mon, 15 Jun 2009 20:58:37 +0100 [thread overview]
Message-ID: <4A36A7ED.2050702@grupopie.com> (raw)
In-Reply-To: <20090610081845.GH16090@infomag.iguana.be>
Wim Van Sebroeck wrote:
> Hi Rui,
>
Hi Wim,
>
>> With your patch, the Intel DG35EC board will not allow my distribution
>> reboot or halt the machine. In order to circumvent that problem, I've
>> made a few addition to your previous patch witch allows the restore of
>> the changed Bit 0 to it's previous value if the module is unloaded.
>> My only doubt is if it should be done every time the gbl_smi_en is zero,
>> or in conjunction with nowayout when the value also equals zero. This
>> patch has what I described and a commented gbl_smi_en only.
>>
>
> Forget the previous patch. I don't like having this hack in the main iTCO_wdt code.
> So I added it to the iTCO_vendor_support code with the necessary warnings.
> Can you test this (please note that the iTCO_vendor_support module needs to be
> loaded with the vendorsupport=911 module parameter).
>
It's working like a charm. Also, the Bit 0 is changed to its original
value, so all reboots work.
I've tested on 2.6.30 and 2.6.27 ( with a few mods... ).
> Thanks in advance,
>
Thank you,
> Wim.
>
Rui
prev parent reply other threads:[~2009-06-15 20:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-30 9:49 [WATCHDOG] iTCO_wdt.c - ICH9 reboot issue - testing wanted Wim Van Sebroeck
2009-04-30 10:33 ` Andriy Gapon
2009-05-01 18:32 ` Wim Van Sebroeck
2009-06-02 16:09 ` Rui Santos
2009-06-03 21:04 ` Wim Van Sebroeck
2009-06-05 18:46 ` Rui Santos
2009-06-10 8:18 ` Wim Van Sebroeck
2009-06-15 19:58 ` Rui Santos [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A36A7ED.2050702@grupopie.com \
--to=rsantos@grupopie.com \
--cc=akpm@linux-foundation.org \
--cc=arch@jonnyjd.net \
--cc=avg@icyb.net.ua \
--cc=bugzilla.kernel@tux.tmfweb.nl \
--cc=denys@visp.net.lb \
--cc=elendil@planet.nl \
--cc=kernel-testers@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=sclark46@earthlink.net \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox