public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rajiv Andrade <srajiv@linux.vnet.ibm.com>
To: Eric Paris <eparis@redhat.com>
Cc: "\"dds (☕)\"" <dds@google.com>,
	seiji.munetoh@gmail.com, tpmdd-devel@lists.sourceforge.net,
	"Mimi Zohar" <zohar@linux.vnet.ibm.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	"Shahbaz Khan" <shaz.linux@gmail.com>
Subject: Re: [tpmdd-devel] TPM drivers support and Linux Integrity Module for 2.6.30
Date: Mon, 15 Jun 2009 18:42:35 -0300	[thread overview]
Message-ID: <4A36C04B.6070204@linux.vnet.ibm.com> (raw)
In-Reply-To: <4A367093.6010206@linux.vnet.ibm.com>


> 2- Forget manufacturer_id and base the decision on the PNP_ID as david
> suggested. I previously considered it but since it would end up in
> modifying tpm_tis_init() prototype (struct device * to struct pnp_dev *)
> and then wouldn't work when loading as a module with force option on, so
> I moved to the manufacturer_id approach.
>
> I'll get back to #2 meanwhile and post the patch, seems not hard to
> accomplish though..
>   
Yes, it wasn't hard, at all, just get the id with to_pnp_dev(dev)->id.

However, the chip is buggy, there's no reason to make a compliant
upstream code modify its behavior just due an 'exception' for a not
compliant hardware.
No need to worry about it too though, the workaround is available as I
pointed earlier (Seiji's)...

Thanks,
Rajiv



  reply	other threads:[~2009-06-15 21:42 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-12  5:59 TPM drivers support and Linux Integrity Module for 2.6.30 Shahbaz Khan
2009-06-12 14:32 ` Mimi Zohar
2009-06-14  3:55   ` Rajiv Andrade
     [not found]     ` <b8394ab90906140015h793aaf51rb9b105910e61fa1@mail.gmail.com>
2009-06-14 19:20       ` [tpmdd-devel] " Rajiv Andrade
2009-06-15 12:28         ` Eric Paris
2009-06-15 16:02           ` Rajiv Andrade
2009-06-15 21:42             ` Rajiv Andrade [this message]
2009-06-16 20:49               ` Eric Paris
2009-06-19 20:09                 ` Rajiv Andrade
     [not found]                 ` <23397_1245442186_n5JK9jDX021038_1245442176.31915.49.camel@blackbox>
2009-06-19 22:23                   ` Jonathan M. McCune
2009-07-01 13:21                     ` Rajiv Andrade
2009-07-01  0:40             ` Andy Isaacson
2009-07-01  5:13               ` dds (☕)
2009-07-01 14:03       ` Fwd: " dds (☕)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A36C04B.6070204@linux.vnet.ibm.com \
    --to=srajiv@linux.vnet.ibm.com \
    --cc=dds@google.com \
    --cc=eparis@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=seiji.munetoh@gmail.com \
    --cc=shaz.linux@gmail.com \
    --cc=tpmdd-devel@lists.sourceforge.net \
    --cc=zohar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox