public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Amerigo Wang <xiyou.wangcong@gmail.com>
Cc: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
	linux-kernel@vger.kernel.org
Subject: Re: [x86] Build error at arch/x86/boot/bioscall.S
Date: Tue, 16 Jun 2009 08:15:49 -0700	[thread overview]
Message-ID: <4A37B725.8070203@zytor.com> (raw)
In-Reply-To: <20090616093056.GD6270@cr0.nay.redhat.com>

Amerigo Wang wrote:
> 
> Ok, how about:
> 
> - movw 68(%esp), %di
> + addl $68, %esp
> + popw %di
> + subl $66, %esp
> 

This will destroy the stack if an untimely interrupt shows up.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.


  parent reply	other threads:[~2009-06-16 18:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-16  7:38 [x86] Build error at arch/x86/boot/bioscall.S Tetsuo Handa
2009-06-16  8:14 ` Amerigo Wang
2009-06-16  8:25   ` Tetsuo Handa
2009-06-16  9:30     ` Amerigo Wang
2009-06-16  9:59       ` Michael S. Zick
2009-06-16 11:40       ` Tetsuo Handa
2009-06-16 15:15       ` H. Peter Anvin [this message]
2009-06-16 15:15   ` H. Peter Anvin
2009-06-16 21:43     ` Tetsuo Handa
2009-06-16 15:12 ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A37B725.8070203@zytor.com \
    --to=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox