From: Rik van Riel <riel@redhat.com>
To: Hugh Dickins <hugh.dickins@tiscali.co.uk>
Cc: Andrea Arcangeli <aarcange@redhat.com>,
Izik Eidus <ieidus@redhat.com>,
linux-kernel@vger.kernel.org, nickpiggin@yahoo.com.au
Subject: Re: running get_user_pages() from kernel thread
Date: Tue, 16 Jun 2009 17:19:01 -0400 [thread overview]
Message-ID: <4A380C45.305@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0906162035240.2933@sister.anvils>
Hugh Dickins wrote:
> [PATCH] mm: pass mm to grab_swap_token
>
> If a kthread happens to use get_user_pages() on an mm (as KSM does),
> there's a chance that it will end up trying to read in a swap page,
> then oops in grab_swap_token() because the kthread has no mm: GUP
> passes down the right mm, so grab_swap_token() ought to be using it.
>
> Signed-off-by: Hugh Dickins <hugh.dickins@tiscali.co.uk>
Provided nobody has a problem with giving the swap token
to a task that isn't actually swapping itself ...
Acked-by: Rik van Riel <riel@redhat.com>
(I don't have any strong opinions either way)
--
All rights reversed.
next prev parent reply other threads:[~2009-06-16 21:19 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-16 18:05 running get_user_pages() from kernel thread Izik Eidus
2009-06-16 18:13 ` Andrea Arcangeli
2009-06-16 18:38 ` Hugh Dickins
2009-06-16 18:55 ` Rik van Riel
2009-06-16 19:45 ` Hugh Dickins
2009-06-16 20:38 ` Andrea Arcangeli
2009-06-16 21:02 ` Hugh Dickins
2009-06-16 21:19 ` Rik van Riel [this message]
2009-06-16 19:20 ` Izik Eidus
2009-06-16 20:45 ` Hugh Dickins
2009-06-16 21:25 ` Izik Eidus
2009-06-16 20:08 ` Johannes Weiner
2009-06-16 20:57 ` Hugh Dickins
2009-06-16 21:50 ` [patch 1/2] mm: make swap token dummies static inlines Johannes Weiner
2009-06-16 21:55 ` Rik van Riel
2009-06-16 21:50 ` [patch 2/2] mm: remove task assumptions from swap token Johannes Weiner
2009-06-16 21:56 ` Rik van Riel
2009-06-17 2:00 ` Minchan Kim
2009-06-17 8:31 ` Johannes Weiner
2009-06-16 21:52 ` running get_user_pages() from kernel thread Johannes Weiner
2009-06-21 13:02 ` [PATCH] mm: pass mm to grab_swap_token Hugh Dickins
2009-06-22 0:32 ` Minchan Kim
2009-06-16 21:16 ` running get_user_pages() from kernel thread Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A380C45.305@redhat.com \
--to=riel@redhat.com \
--cc=aarcange@redhat.com \
--cc=hugh.dickins@tiscali.co.uk \
--cc=ieidus@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox