From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1754905AbZFRDSR@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754905AbZFRDSR (ORCPT <rfc822;w@1wt.eu>);
	Wed, 17 Jun 2009 23:18:17 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752144AbZFRDSD
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Wed, 17 Jun 2009 23:18:03 -0400
Received: from cn.fujitsu.com ([222.73.24.84]:57634 "EHLO song.cn.fujitsu.com"
	rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP
	id S1751291AbZFRDSC (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 17 Jun 2009 23:18:02 -0400
Message-ID: <4A39B25C.2040801@cn.fujitsu.com>
Date: Thu, 18 Jun 2009 11:19:56 +0800
From: Lai Jiangshan <laijs@cn.fujitsu.com>
User-Agent: Thunderbird 2.0.0.6 (Windows/20070728)
MIME-Version: 1.0
To: Ingo Molnar <mingo@elte.hu>
CC: Zhaolei <zhaolei@cn.fujitsu.com>, Thomas Gleixner <tglx@linutronix.de>,
       Peter Zijlstra <a.p.zijlstra@chello.nl>,
       Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
       Steven Rostedt <rostedt@goodmis.org>, linux-kernel@vger.kernel.org,
       fweisbec@gmail.com, Li Zefan <lizf@cn.fujitsu.com>,
       Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>,
       Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH RFC] softirq: fix ksoftirq starved
References: <20090511151353.GA14391@Krystal> <4A094677.5090900@cn.fujitsu.com> <4A0BF82A.2070208@cn.fujitsu.com> <20090514124013.GC21241@Krystal> <alpine.DEB.2.00.0905140926010.30591@gandalf.stny.rr.com> <4A0CCB2E.10202@cn.fujitsu.com> <6A70E08D65F749FA92475F8BA1F9510D@zhaoleiwin> <20090519082435.GB15286@elte.hu> <4A31BF1D.1050400@cn.fujitsu.com> <4A32251C.8060001@cn.fujitsu.com> <20090617145333.GD6846@elte.hu>
In-Reply-To: <20090617145333.GD6846@elte.hu>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Ingo Molnar wrote:
> * Lai Jiangshan <laijs@cn.fujitsu.com> wrote:
> 
>> --- a/kernel/sched.c
>> +++ b/kernel/sched.c
>> @@ -5307,6 +5307,7 @@ need_resched:
>>  	release_kernel_lock(prev);
>>  need_resched_nonpreemptible:
>>  
>> +	schedule_softirq_check();
>>  	schedule_debug(prev);
> 
> hm, this slows down the scheduler fast-path ...
> 
> 	Ingo
> 
> 

It's true. But:

The overheads are:

Overhead-A: the function call statement "schedule_softirq_check();"
It can be gotten rid off by a macro or inline function.

Overhead-B: __get_cpu_var() and the test statement.

Overhead-C: do_softirq()
In my patch, we test a variable and then call do_softirq() when
the variable is true. do_softirq() can be called from process
context or from schedule() or by any other ways, but it must be
called and avoids starvation in this condition.
So we need pay this overhead. It is no worse than before.

Is it a critical thing when it slows down the scheduler fast-path
because of the "Overhead-B"?

Or I misunderstand something?

	Thanks, Lai.