Re: [PATCH 12/16] x86, mce: squash mce_intel.c into therm_throt.c

huang ying
2009-06-18T05:49:38Z

2009/6/15 Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>:
> move intel_init_thermal() into therm_throt.c
>
> Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
> ---
>  arch/x86/kernel/cpu/mcheck/Makefile      |    2 +-
>  arch/x86/kernel/cpu/mcheck/mce_intel.c   |   73 ------------------------------
>  arch/x86/kernel/cpu/mcheck/therm_throt.c |   66 +++++++++++++++++++++++++++
>  3 files changed, 67 insertions(+), 74 deletions(-)
>  delete mode 100644 arch/x86/kernel/cpu/mcheck/mce_intel.c

Why we need this patch? I think the design principle behind MCE is to
separate vendor/cpu specific code into different files. At least
#ifdef CONFIG_X86_MCE_INTEL should be used around moved code.

Best Regards,
Huang Ying