public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Li Zefan <lizf@cn.fujitsu.com>
To: Steven Rostedt <rostedt@goodmis.org>, Ingo Molnar <mingo@elte.hu>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 0/5] tracing: seqfile fixes
Date: Fri, 19 Jun 2009 14:42:58 +0800	[thread overview]
Message-ID: <4A3B3372.4040608@cn.fujitsu.com> (raw)

While testing syscall tracepoints proposed by Jason, I found some
entries were missing when reading available_events.

It turned out there's bug in seqfile handling. The bug is, it's
wrong to increment @pos in seq start().

I fixed similar bugs in some other places. (the last patch fixes
a different seqfile bug)

[PATCH 1/5] tracing/events: don't increment @pos in s_start()
[PATCH 2/5] tracing_bprintk: don't increment @pos in t_start()
[PATCH 3/5] trace_stat: don't increment @pos in stat_seq_start()
[PATCH 4/5] ftrace: don't increment @pos in g_start()
[PATCH 5/5] tracing: reset iterator in t_start()
---
 kernel/trace/ftrace.c       |   28 +++++++++++++---------------
 kernel/trace/trace.c        |   18 ++++--------------
 kernel/trace/trace_events.c |   28 ++++++++++++++++++++++------
 kernel/trace/trace_printk.c |   26 ++++++--------------------
 kernel/trace/trace_stat.c   |    6 +-----
 5 files changed, 46 insertions(+), 60 deletions(-)




             reply	other threads:[~2009-06-19  6:41 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-19  6:42 Li Zefan [this message]
2009-06-19  6:45 ` [PATCH 1/5] tracing/events: don't increment @pos in s_start() Li Zefan
2009-06-19  6:46 ` [PATCH 2/5] tracing_bprintk: don't increment @pos in t_start() Li Zefan
2009-06-19  9:39   ` Wang Liming
2009-06-22  0:38     ` Li Zefan
2009-06-22  2:08       ` Wang Liming
2009-06-22  3:01         ` Li Zefan
2009-06-19  6:46 ` [PATCH 3/5] trace_stat: don't increment @pos in stat_seq_start() Li Zefan
2009-06-19  6:47 ` [PATCH 4/5] ftrace: don't increment @pos in g_start() Li Zefan
2009-06-19  8:59   ` [PATCH] " Liming Wang
2009-06-19  9:45     ` Li Zefan
2009-06-22  0:45       ` Li Zefan
2009-06-22  2:42         ` Wang Liming
2009-06-22  3:15           ` Li Zefan
2009-06-22  3:08             ` Wang Liming
2009-06-19  6:48 ` [PATCH 5/5] tracing: reset iterator in t_start() Li Zefan
2009-06-23  6:48   ` Wang Liming
2009-06-23  7:19     ` Li Zefan
2009-06-23  7:19       ` Wang Liming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A3B3372.4040608@cn.fujitsu.com \
    --to=lizf@cn.fujitsu.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox