From: Greg Ungerer <gerg@snapgear.com>
To: uClinux development list <uclinux-dev@uclinux.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [uClinux-dev] [PATCH] m68k: restore lost coldfire CLOCK_TICK_RATE
Date: Mon, 22 Jun 2009 13:18:55 +1000 [thread overview]
Message-ID: <4A3EF81F.1060300@snapgear.com> (raw)
In-Reply-To: <20090620201147.GA14095@frolo.macqel>
HI Philippe,
Philippe De Muyter wrote:
> Hello list,
>
> The good definition of CLOCK_TICK_RATE for coldfires has been lost in the
> merge of m68k and m68knommu include files. Restore it. Culprit :
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=ebafc17468d58bd903c886175ca84a4edc69ae1d;hp=34055b806a6334624e7e8af6eefc3aee42372a85
>
> Signed-off-by: Philippe De Muyter <phdm@macqel.be>
Is it needed?
What is broken with the existing value?
Regards
Greg
> diff -r 8dcc271a81a8 arch/m68k/include/asm/timex.h
> --- a/arch/m68k/include/asm/timex.h Thu Jun 18 14:07:46 2009 -0700
> +++ b/arch/m68k/include/asm/timex.h Sat Jun 20 21:46:25 2009 +0200
> @@ -3,10 +3,23 @@
> *
> * m68k architecture timex specifications
> */
> -#ifndef _ASMm68k_TIMEX_H
> -#define _ASMm68k_TIMEX_H
> +#ifndef _ASMm68K_TIMEX_H
> +#define _ASMm68K_TIMEX_H
>
> +#ifdef CONFIG_COLDFIRE
> +/*
> + * CLOCK_TICK_RATE should give the underlying frequency of the tick timer
> + * to make ntp work best. For Coldfires, that's the main clock.
> + */
> +#include <asm/coldfire.h>
> +#define CLOCK_TICK_RATE MCF_CLK
> +#else
> +/*
> + * This default CLOCK_TICK_RATE is probably wrong for many 68k boards
> + * Users of those boards will need to check and modify accordingly
> + */
> #define CLOCK_TICK_RATE 1193180 /* Underlying HZ */
> +#endif
>
> typedef unsigned long cycles_t;
>
> _______________________________________________
> uClinux-dev mailing list
> uClinux-dev@uclinux.org
> http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
> This message was resent by uclinux-dev@uclinux.org
> To unsubscribe see:
> http://mailman.uclinux.org/mailman/options/uclinux-dev
>
--
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com
SnapGear Group, McAfee PHONE: +61 7 3435 2888
825 Stanley St, FAX: +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia WEB: http://www.SnapGear.com
next prev parent reply other threads:[~2009-06-22 3:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-20 20:11 [PATCH] m68k: restore lost coldfire CLOCK_TICK_RATE Philippe De Muyter
2009-06-22 3:18 ` Greg Ungerer [this message]
2009-06-24 21:11 ` [uClinux-dev] " Philippe De Muyter
2009-06-25 0:33 ` Greg Ungerer
2009-06-25 11:30 ` Arnd Bergmann
2009-08-12 6:42 ` Greg Ungerer
2009-08-13 2:25 ` Philippe De Muyter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A3EF81F.1060300@snapgear.com \
--to=gerg@snapgear.com \
--cc=linux-kernel@vger.kernel.org \
--cc=uclinux-dev@uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox