From: Bernd Schmidt <bernds_cb1@t-online.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Blackfin Architecture Team
<uclinux-dist-devel@blackfin.uclinux.org>,
David Howells <dhowells@redhat.com>,
stable@kernel.org
Subject: Fix for shared flat binary format in 2.6.30
Date: Mon, 22 Jun 2009 11:36:30 +0100 [thread overview]
Message-ID: <4A3F5EAE.7020402@t-online.de> (raw)
[-- Attachment #1: Type: text/plain, Size: 513 bytes --]
This fixes a crash in 2.6.30 with shared flat binaries. prepare_binfmt
now requires a cred pointer to be set up, which isn't done in binfmt_flat.c.
Signed-off-by: Bernd Schmidt <bernds_cb1@t-online.de>
Acked-by: David Howells <dhowells@redhat.com>
--
This footer brought to you by insane German lawmakers.
Analog Devices GmbH Wilhelm-Wagenfeld-Str. 6 80807 Muenchen
Sitz der Gesellschaft Muenchen, Registergericht Muenchen HRB 40368
Geschaeftsfuehrer Thomas Wessel, William A. Martin, Margaret Seif
[-- Attachment #2: cred-flat.diff --]
[-- Type: text/plain, Size: 723 bytes --]
Index: fs/binfmt_flat.c
===================================================================
--- fs/binfmt_flat.c (revision 6766)
+++ fs/binfmt_flat.c (working copy)
@@ -853,14 +853,23 @@ static int load_flat_shared_library(int
/* Open the file up */
bprm.filename = buf;
bprm.file = open_exec(bprm.filename);
+ bprm.cred = NULL;
res = PTR_ERR(bprm.file);
if (IS_ERR(bprm.file))
return res;
+ bprm.cred = prepare_exec_creds();
+ if (!bprm.cred)
+ goto out;
+
res = prepare_binprm(&bprm);
if (res <= (unsigned long)-4096)
res = load_flat_file(&bprm, libs, id, NULL, NULL);
+out:
+ if (bprm.cred)
+ abort_creds (bprm.cred);
+
if (bprm.file) {
allow_write_access(bprm.file);
fput(bprm.file);
next reply other threads:[~2009-06-22 10:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-22 10:36 Bernd Schmidt [this message]
2009-06-22 18:44 ` Fix for shared flat binary format in 2.6.30 Linus Torvalds
2009-06-22 18:56 ` Linus Torvalds
2009-06-22 19:35 ` [PATCH] FLAT: fix uninitialized ptr with shared libs Mike Frysinger
2009-06-22 20:48 ` Linus Torvalds
2009-06-22 21:00 ` [Uclinux-dist-devel] " Mike Frysinger
2009-06-23 10:14 ` Bernd Schmidt
2009-06-29 23:44 ` [stable] " Greg KH
2009-06-22 20:39 ` Fix for shared flat binary format in 2.6.30 John Stoffel
2009-06-22 21:06 ` Linus Torvalds
2009-06-23 1:59 ` John Stoffel
2009-06-23 2:44 ` Linus Torvalds
2009-06-25 7:12 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A3F5EAE.7020402@t-online.de \
--to=bernds_cb1@t-online.de \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox