From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: acme@redhat.com, mel@csn.ul.ie, akpm@linux-foundation.org,
mingo@elte.hu, linux-kernel@vger.kernel.org, linux-mm@kvack.org,
htd@fancy-poultry.org
Subject: Re: [PATCH 3/3] net-dccp: Suppress warning about large allocations from DCCP
Date: Tue, 23 Jun 2009 13:03:54 +0200 [thread overview]
Message-ID: <4A40B69A.2020703@gmail.com> (raw)
In-Reply-To: <20090622.211927.245716932.davem@davemloft.net>
David Miller a écrit :
> From: Arnaldo Carvalho de Melo <acme@redhat.com>
> Date: Mon, 22 Jun 2009 23:39:36 -0300
>
>> Em Mon, Jun 22, 2009 at 04:15:02PM -0700, David Miller escreveu:
>>> It's probably much more appropriate to make this stuff use
>>> alloc_large_system_hash(), like TCP does (see net/ipv4/tcp.c
>>> tcp_init()).
>>>
>>> All of this complicated DCCP hash table size computation code will
>>> simply disappear. And it'll fix the warning too :-)
>> He mentioned that in the conversation that lead to this new patch
>> series, problem is that alloc_large_system_hash is __init, so when you
>> try to load dccp.ko it will not be available.
>
> Fair enough.
>
> It's such an unfortunate duplication of code, it's likely therefore
> better to remove the __init tag and export that symbol.
Agreed, I once considered using this function for futex hash table allocation
and just forgot about it...
But it has some bootmem references, it might need more work than just exporting it.
next prev parent reply other threads:[~2009-06-23 11:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-22 15:43 [PATCH 0/3] Suppress page allocator warnings about order >= MAX_ORDER Mel Gorman
2009-06-22 15:43 ` [PATCH 1/3] page-allocator: Allow too high-order warning messages to be suppressed with __GFP_NOWARN Mel Gorman
2009-06-22 15:43 ` [PATCH 2/3] profile: Suppress warning about large allocations when profile=1 is specified Mel Gorman
2009-06-22 15:43 ` [PATCH 3/3] net-dccp: Suppress warning about large allocations from DCCP Mel Gorman
2009-06-22 23:15 ` David Miller
2009-06-23 2:39 ` Arnaldo Carvalho de Melo
2009-06-23 4:19 ` David Miller
2009-06-23 11:03 ` Eric Dumazet [this message]
2009-06-23 11:05 ` David Miller
2009-06-23 13:42 ` Arnaldo Carvalho de Melo
2009-06-23 8:48 ` Mel Gorman
-- strict thread matches above, loose matches on Subject: below --
2009-07-15 11:23 [PATCH 0/3] Suppress page allocator warnings about order >= MAX_ORDER (resend) Mel Gorman
2009-07-15 11:23 ` [PATCH 3/3] net-dccp: Suppress warning about large allocations from DCCP Mel Gorman
2009-07-15 13:56 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A40B69A.2020703@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=acme@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=htd@fancy-poultry.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox