From: Masami Hiramatsu <mhiramat@redhat.com>
To: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
lkml <linux-kernel@vger.kernel.org>,
systemtap <systemtap@sources.redhat.com>,
DLE <dle-develop@lists.sourceforge.net>,
Jim Keniston <jkenisto@us.ibm.com>,
Christoph Hellwig <hch@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Anders Kaseorg <andersk@ksplice.com>,
Tim Abbott <tabbott@ksplice.com>
Subject: Re: [RFC][ PATCH -tip v2 4/7] kprobes: kprobes jump optimization core
Date: Tue, 23 Jun 2009 09:11:53 -0400 [thread overview]
Message-ID: <4A40D499.6000805@redhat.com> (raw)
In-Reply-To: <20090623125806.GD8340@linux.vnet.ibm.com>
Srikar Dronamraju wrote:
>> + /* .insn_size is initialized later */
>> + .nr_garbage = 0,
>> +};
>
>> +#if defined(CONFIG_OPTPROBES) && defined(__ARCH_WANT_KPROBES_INSN_SLOT)
>> + /* Init kprobe_optinsn_slots */
>> + kprobe_optinsn_slots.insn_size = MAX_OPTINSN_SIZE;
>> +#endif
>> +
>
> What would be be the size of kprobe_optinsn_slots.insn_size if
> CONFIG_OPTPROBES is defined but __ARCH_WANT_KPROBES_INSN_SLOT is not
> defined?
No problem. If __ARCH_WANT_KPROBES_INSN_SLOT is not defined,
kprobe_optinsn_slots doesn't exist.
Thank you,
>
> -Srikar
--
Masami Hiramatsu
Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division
e-mail: mhiramat@redhat.com
next prev parent reply other threads:[~2009-06-23 13:12 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-22 21:22 [RFC][ PATCH -tip v2 0/7] kprobes: Kprobes jump optimization support Masami Hiramatsu
2009-06-22 21:23 ` [RFC][ PATCH -tip v2 1/7] kprobes: use list instead of hlist for insn_pages Masami Hiramatsu
2009-06-22 21:23 ` [RFC][ PATCH -tip v2 2/7] kprobes: introducing generic insn_slot framework Masami Hiramatsu
2009-06-27 20:09 ` Steven Rostedt
2009-06-29 21:09 ` Masami Hiramatsu
2009-06-22 21:23 ` [RFC][ PATCH -tip v2 3/7] Kbuild: disable gcc crossjumping Masami Hiramatsu
2009-06-27 20:13 ` Steven Rostedt
2009-07-17 20:28 ` Sam Ravnborg
2009-07-17 21:13 ` Masami Hiramatsu
2009-07-17 21:15 ` Masami Hiramatsu
2009-07-17 21:19 ` Sam Ravnborg
2009-06-22 21:23 ` [RFC][ PATCH -tip v2 4/7] kprobes: kprobes jump optimization core Masami Hiramatsu
2009-06-23 12:58 ` Srikar Dronamraju
2009-06-23 13:11 ` Masami Hiramatsu [this message]
2009-06-22 21:23 ` [RFC][ PATCH -tip v2 5/7] kprobes: x86: cleanup save/restore registers Masami Hiramatsu
2009-06-22 21:23 ` [RFC][ PATCH -tip v2 6/7] kprobes: x86: support kprobes jump optimization on x86 Masami Hiramatsu
2009-06-22 21:23 ` [RFC][ PATCH -tip v2 7/7] kprobes: add documents of jump optimization Masami Hiramatsu
2009-06-23 11:42 ` [RFC][ PATCH -tip v2 0/7] kprobes: Kprobes jump optimization support Ingo Molnar
2009-06-23 14:06 ` Masami Hiramatsu
2009-06-23 19:40 ` Ingo Molnar
2009-06-23 21:54 ` Masami Hiramatsu
2009-06-23 22:08 ` Masami Hiramatsu
2009-06-23 12:09 ` Andi Kleen
2009-06-23 13:50 ` Masami Hiramatsu
2009-06-23 16:34 ` Andi Kleen
2009-06-23 17:28 ` Masami Hiramatsu
2009-06-23 20:37 ` Andi Kleen
2009-06-23 20:48 ` Masami Hiramatsu
2009-06-26 23:20 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A40D499.6000805@redhat.com \
--to=mhiramat@redhat.com \
--cc=ananth@in.ibm.com \
--cc=andersk@ksplice.com \
--cc=dle-develop@lists.sourceforge.net \
--cc=fweisbec@gmail.com \
--cc=hch@infradead.org \
--cc=hpa@zytor.com \
--cc=jkenisto@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=srikar@linux.vnet.ibm.com \
--cc=systemtap@sources.redhat.com \
--cc=tabbott@ksplice.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox