From: Gregory Haskins <gregory.haskins@gmail.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Gregory Haskins <ghaskins@novell.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
avi@redhat.com, paulmck@linux.vnet.ibm.com,
davidel@xmailserver.org, mingo@elte.hu, rusty@rustcorp.com.au
Subject: Re: [KVM PATCH v3 3/3] KVM: Fix races in irqfd using new eventfd_kref_get interface
Date: Tue, 23 Jun 2009 10:55:59 -0400 [thread overview]
Message-ID: <4A40ECFF.7060706@gmail.com> (raw)
In-Reply-To: <4A3FBFF1.8050504@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 461 bytes --]
Gregory Haskins wrote:
> Michael S. Tsirkin wrote:
>
>
>> And note that multiple works can run on irqfd
>> in parallel.
>>
>>
>
> They can? I thought work-queue items were guaranteed to only schedule
> once? If what you say is true, its broken, I agree, and Ill need to
> revisit. Let me get back to you.
>
<sigh> Yep, you are right. This is broken in my code. :(
Will address in the next spin. Good catch.
-Greg
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 266 bytes --]
prev parent reply other threads:[~2009-06-23 14:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-22 16:05 [KVM PATCH v3 0/3] irqfd/eventfd fixes Gregory Haskins
2009-06-22 16:05 ` [KVM PATCH v3 1/3] kvm: prepare irqfd for having interrupts disabled during eventfd->release Gregory Haskins
2009-06-22 16:05 ` [KVM PATCH v3 2/3] eventfd: add internal reference counting to fix notifier race conditions Gregory Haskins
2009-06-22 16:05 ` [KVM PATCH v3 3/3] KVM: Fix races in irqfd using new eventfd_kref_get interface Gregory Haskins
2009-06-22 16:57 ` Michael S. Tsirkin
2009-06-22 17:31 ` Gregory Haskins
2009-06-22 17:45 ` Michael S. Tsirkin
2009-06-22 18:03 ` Gregory Haskins
2009-06-22 18:26 ` Michael S. Tsirkin
2009-06-22 18:11 ` Davide Libenzi
2009-06-22 18:32 ` Michael S. Tsirkin
2009-06-22 18:41 ` Davide Libenzi
2009-06-22 18:52 ` Michael S. Tsirkin
2009-06-23 14:55 ` Gregory Haskins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A40ECFF.7060706@gmail.com \
--to=gregory.haskins@gmail.com \
--cc=avi@redhat.com \
--cc=davidel@xmailserver.org \
--cc=ghaskins@novell.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mst@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox