Re: [PATCH 2/8] SFI: include/linux/sfi.h

["H. Peter Anvin" <hpa@zytor.com>]

Ingo Molnar wrote:
> * Feng Tang <feng.tang@intel.com> wrote:
> 
>> On Tue, 23 Jun 2009 16:00:47 +0800
>> Ingo Molnar <mingo@elte.hu> wrote:
>>
>>> * Feng Tang <feng.tang@intel.com> wrote:
>>>
>>>> For these arch_early_ioremap/arch_early_iounmap API, do you mean 
>>>> we should put it in a sfi.h under "asm" folder? The reason we put 
>>>> it here is to give a arch independent API declaration here and let 
>>>> each arch implement its own func.
>>> Yeah, i'd suggest to create a new early-remap.h and 
>>> early-remap.c kind of file to collect the existing bits for 
>>> that. It's a bit ugly (not really the fault of SFI - these are 
>>> pre-existing facilities) and might need some love - we better 
>>> move it apart so that the light of attention shines on it.
>>>
>>> What's the target merge of the SFI stuff, 2.6.31?
>> AFAIK, Len's target is for 2.6.32
> 
> Ah, ok - then there's time. The code is almost good for .31 btw ;-)
> 

The code is really quite clean; I recommended to Len that he target
2.6.32 not because of the quality of the code, but just to get it plenty
of time to get properly reviewed and any architectural issues getting
fixed properly.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.