Re: [PATCH] can: let SJA1000 driver depend on HAS_IOMEM

Oliver Hartkopp
2009-06-24T06:52:55Z

Wolfgang Grandegger wrote:
> Heiko Carstens wrote:

>> Index: linux-2.6/drivers/net/can/Kconfig
>> ===================================================================
>> --- linux-2.6.orig/drivers/net/can/Kconfig
>> +++ linux-2.6/drivers/net/can/Kconfig
>> @@ -36,7 +36,7 @@ config CAN_CALC_BITTIMING
>> If unsure, say Y.
>>
>> config CAN_SJA1000
>> - depends on CAN_DEV
>> + depends on CAN_DEV && HAS_IOMEM
>> tristate "Philips SJA1000"
>> ---help---
>> Driver for the SJA1000 CAN controllers from Philips or NXP
>
> Hm, this Kconfig entry is not directly responsible for building
> sja1000_platform.o. It builds sja1000.o, which does not rely on
> HAS_IOMEM. It should be added to "config CAN_SJA1000_PLATFORM" instead.

Hi Wolfgang,

the question is, if we should add HAS_IOMEM to almost every SJA1000 depended
driver like SJA1000_PLATFORM, SJA1000_OF_PLATFORM, EMS_PCI and KVASER_PCI ???

Is it possible to have a support for the SJA1000 that does *not* depend on
HAS_IOMEM?

Regards,
Oliver