Re: [PATCH] Hugepages should be accounted as unevictable pages.

Alok Kataria
2009-06-23T04:46:56Z

On Mon, 2009-06-22 at 20:25 -0700, KOSAKI Motohiro wrote:
> > Looking at the output of /proc/meminfo, a user might get confused in thinking
> > that there are zero unevictable pages, though, in reality their can be
> > hugepages which are inherently unevictable.
> >
> > Though hugepages are not handled by the unevictable lru framework, they are
> > infact unevictable in nature and global statistics counter should reflect that.
> >
> > For instance, I have allocated 20 huge pages on my system, meminfo shows this
> >
> > Unevictable: 0 kB
> > Mlocked: 0 kB
> > HugePages_Total: 20
> > HugePages_Free: 20
> > HugePages_Rsvd: 0
> > HugePages_Surp: 0
> >
> > After the patch:
> >
> > Unevictable: 81920 kB
> > Mlocked: 0 kB
> > HugePages_Total: 20
> > HugePages_Free: 20
> > HugePages_Rsvd: 0
> > HugePages_Surp: 0
>
> At first, We should clarify the spec of unevictable.
> Currently, Unevictable field mean the number of pages in unevictable-lru
> and hugepage never insert any lru.
>
> I think this patch will change this rule.

I agree, and that's why I added a comment to the documentation file to
that effect. If you think its not explicit or doesn't explain what its
supposed to we can add something more there.

IMO, the proc output should give the total number of unevictable pages
in the system and, since hugepages are also in fact unevictable so I
don't see a reason why they shouldn't be accounted accordingly.
What do you think ?

Thanks,
Alok
>
>
>