Re: [PATCH] Hugepages should be accounted as unevictable pages.

KAMEZAWA Hiroyuki
2009-06-23T05:13:31Z

On Tue, 23 Jun 2009 14:05:47 +0900 (JST)
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:
> I'm not sure this unevictable definition is good idea or not. currently
> hugepage isn't only non-account memory, but also various kernel memory doesn't
> account.
>
> one of drawback is that zone_page_state(UNEVICTABLE) lost to mean #-of-unevictable-pages.
> e.g. following patch is wrong?
>
> fs/proc/meminfo.c meminfo_proc_show()
> ----------------------------
> - K(pages[LRU_UNEVICTABLE]),
> + K(pages[LRU_UNEVICTABLE]) + hstate->nr_huge_pages,
>
>
> Plus, I didn't find any practical benefit in this patch. do you have it?
> or You only want to natural definition?
>
> I don't have any strong oppose reason, but I also don't have any strong
> agree reason.
>
I think "don't include Hugepage" is sane. Hugepage is something _special_, now.

Thanks,
-Kame