Re: Regression with commit f9cde5f in 2.6.30-gitX

Larry Finger
2009-06-24T16:52:54Z

Gary Hade wrote:

> I think the resource array needs to be larger. Can you try
> the below patch?
>
> Gary
>
> --- linux-2.6.30-rc8/include/linux/pci.h.ORIG 2009-06-24 09:03:41.000000000 -0700
> +++ linux-2.6.30-rc8/include/linux/pci.h 2009-06-24 09:06:50.000000000 -0700
> @@ -319,7 +319,7 @@ static inline void pci_add_saved_cap(str
> }
>
> #ifndef PCI_BUS_NUM_RESOURCES
> -#define PCI_BUS_NUM_RESOURCES 16
> +#define PCI_BUS_NUM_RESOURCES 20
> #endif
>
> #define PCI_REGION_FLAG_MASK 0x0fU /* These bits of resource flags tell us the PCI region flags */

As noted, I had already tested and posted that increasing
PCI_BUS_NUM_RESOURCES from 16 to 24 "solves" the problem as does
increasing it to 20, but I wonder if that isn't just papering over the
bug, which will reoccur when there is a machine with even a more
complicated PCI bus structure even more complicated than mine. Of
course, increasing it to something as large as 64 might delay the
problem "forever".

Larry