Re: Regression with commit f9cde5f in 2.6.30-gitX

Larry Finger
2009-06-24T14:22:01Z

Jaswinder Singh Rajput wrote:
> On Tue, 2009-06-23 at 20:33 -0500, Larry Finger wrote:
>> My latest pull from Linus's tree fails to boot. Bisection leads to the
>> commit entitled "x86/ACPI: Correct maximum allowed _CRS returned
>> resources and warn if exceeded" with hash
>> f9cde5ffed17bf74f6bef042d99edb0622f58576. I have been unable to
>> capture the first error message as it scrolls off the screen, but the
>> second hits the WARN_ON at drivers/ata/ahci.c:695 in routine
>> ahci_enable_ahci() because HOST_AHCI_EN is not set.
>>
>
> This patch fixes boot failure on my AMD 64 laptop, can you please test
> this patch:
>
> [PATCH] x86: fix _CRS resources return handling
>
> We need to check for info->res_num and only handle for < PCI_BUS_NUM_RESOURCES
>
> Also set info->bus->resource[info->res_num] for _CRS resources return handling
>
> Fixed boot failure on some machine.
>
> Reported-by: Larry Finger <Larry.Finger@lwfinger.net>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
> ---
> arch/x86/pci/acpi.c | 16 ++++++++++------
> 1 files changed, 10 insertions(+), 6 deletions(-)

Tested-by: Larry Finger <Larry.Finger@lwfinger.net>

Thanks for the patch. With it, my machine boots with the latest
2.6.30-gitX.

For the record, the printout from the patch results in the following:

PCI: Failed to allocate 0xd0000-0xd3fff from PCI mem for PCI Bus 0000:00
PCI: Failed to allocate 0xec000-0xeffff from PCI mem for PCI Bus
0000:00 due to _CRS returning more than 13 resource descriptors
PCI: Failed to allocate 0xf0000-0xfffff from PCI mem for PCI Bus
0000:00 due to _CRS returning more than 13 resource descriptors
PCI: Failed to allocate 0xc0000000-0xfebfffff from PCI mem for PCI Bus
0000:00 due to _CRS returning more than 13 resource descriptors

Larry