Re: [PATCH 00/13] revised Coldfire generic GPIO (mk68nommu)

[Greg Ungerer <gerg@snapgear.com>]

Hi Steven,

sfking@fdwdc.com wrote:
> Revised implementation of generic gpio for the Freescale Coldfire family of
> processors (m68knommu).   It uses gpiolib and provides both fast inline
> operations when the gpio is a compile time constant and slower outline
> operations dispatched via gpiolib when the gpio is a variable. 
> 
> There are also hooks for implementing pin multiplexing but that part isn't
> finished yet.
> 
> 
> The major difference with the previous version is the move to a per-platform
> setup code as suggested by Greg Ungerer <gerg@snapgear.com>.
> 
> Additionally, it fixes the definition of the TIMER gpio pins in the 5271
> (thanks to Richard Retanubun <RichardRetanubun@ruggedcom.com>).

This looks pretty good to me.
Do you want me to apply the the m68knommu git tree?
(Ideally I'll push it to Linus in the 2.6.32 merge window).

Regards
Greg



------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg@snapgear.com
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
825 Stanley St,                             FAX:         +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia         WEB: http://www.SnapGear.com