From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757552AbZFXJcx (ORCPT ); Wed, 24 Jun 2009 05:32:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756478AbZFXJc2 (ORCPT ); Wed, 24 Jun 2009 05:32:28 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:53018 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1756722AbZFXJc1 (ORCPT ); Wed, 24 Jun 2009 05:32:27 -0400 Message-ID: <4A41F2DB.4020102@cn.fujitsu.com> Date: Wed, 24 Jun 2009 17:33:15 +0800 From: Li Zefan User-Agent: Thunderbird 2.0.0.9 (X11/20071115) MIME-Version: 1.0 To: Ingo Molnar CC: Steven Rostedt , Frederic Weisbecker , LKML Subject: Re: [PATCH] tracing: fix trace_buf_size boot option References: <4A41F165.2000906@cn.fujitsu.com> In-Reply-To: <4A41F165.2000906@cn.fujitsu.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > - ret = strict_strtoul(str, 0, &buf_size); > + buf_size = memparse(str, &opt); Sorry, there's a typo: s/opt/str. I forgot to commit the change after fixing it. ======================== [PATCH] tracing: fix trace_buf_size boot option We should be able to specify [KMG] when setting trace_buf_size boot option, as documented in kernel-parameters.txt [ Impact: allow to specify [KMG] in trace_buf_size boot option ] Signed-off-by: Li Zefan --- Documentation/kernel-parameters.txt | 3 ++- kernel/trace/trace.c | 5 ++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt index 256a650..421f1e6 100644 --- a/Documentation/kernel-parameters.txt +++ b/Documentation/kernel-parameters.txt @@ -2446,7 +2446,8 @@ and is between 256 and 4096 characters. It is defined in the file tp720= [HW,PS2] - trace_buf_size=nn[KMG] [ftrace] will set tracing buffer size. + trace_buf_size=nn[KMG] + [FTRACE] will set tracing buffer size. trix= [HW,OSS] MediaTrix AudioTrix Pro Format: diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index 3bb3100..3aa0a0d 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -284,13 +284,12 @@ void trace_wake_up(void) static int __init set_buf_size(char *str) { unsigned long buf_size; - int ret; if (!str) return 0; - ret = strict_strtoul(str, 0, &buf_size); + buf_size = memparse(str, &str); /* nr_entries can not be zero */ - if (ret < 0 || buf_size == 0) + if (buf_size == 0) return 0; trace_buf_size = buf_size; return 1; -- 1.5.4.rc3