* [PATCH v2 1/1] Char: tty, fix tty_port_block_til_ready waiting
@ 2009-06-18 7:46 Jiri Slaby
2009-06-23 23:30 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Jiri Slaby @ 2009-06-18 7:46 UTC (permalink / raw)
To: alan; +Cc: Andrew Morton, linux-kernel, Jiri Slaby
Use DEFINE_WAIT instead DECLARE_WAITQUEUE, because we use
prepare/finish_wait since commit
3e3b5c087799e536871c8261b05bc28e4783c8da
(tty: use prepare/finish_wait)
Otherwise we would oops in finish_wait.
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
---
drivers/char/tty_port.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/char/tty_port.c b/drivers/char/tty_port.c
index 62dadfc..4e862a7 100644
--- a/drivers/char/tty_port.c
+++ b/drivers/char/tty_port.c
@@ -193,7 +193,7 @@ int tty_port_block_til_ready(struct tty_port *port,
{
int do_clocal = 0, retval;
unsigned long flags;
- DECLARE_WAITQUEUE(wait, current);
+ DEFINE_WAIT(wait);
int cd;
/* block if port is in the process of being closed */
--
1.6.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2 1/1] Char: tty, fix tty_port_block_til_ready waiting
2009-06-18 7:46 [PATCH v2 1/1] Char: tty, fix tty_port_block_til_ready waiting Jiri Slaby
@ 2009-06-23 23:30 ` Andrew Morton
2009-06-24 11:41 ` Jiri Slaby
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2009-06-23 23:30 UTC (permalink / raw)
To: Jiri Slaby; +Cc: alan, linux-kernel, jirislaby
On Thu, 18 Jun 2009 09:46:13 +0200
Jiri Slaby <jirislaby@gmail.com> wrote:
> Use DEFINE_WAIT instead DECLARE_WAITQUEUE, because we use
> prepare/finish_wait since commit
> 3e3b5c087799e536871c8261b05bc28e4783c8da
> (tty: use prepare/finish_wait)
>
> Otherwise we would oops in finish_wait.
>
<scratches head for a while>
OK, here's a better changelog:
Since commit 3e3b5c087799e536871c8261b05bc28e4783c8da ("tty: use
prepare/finish_wait"), tty_port_block_til_ready() is using
prepare_to_wait()/finish_wait(). Those functions require that
the wait_queue_t be initialised with .func=autoremove_wake_function,
via DEFINE_WAIT().
But the conversion from DECLARE_WAITQUEUE() to DEFINE_WAIT() was
not made, so this code will oops in finish_wait().
>
> diff --git a/drivers/char/tty_port.c b/drivers/char/tty_port.c
> index 62dadfc..4e862a7 100644
> --- a/drivers/char/tty_port.c
> +++ b/drivers/char/tty_port.c
> @@ -193,7 +193,7 @@ int tty_port_block_til_ready(struct tty_port *port,
> {
> int do_clocal = 0, retval;
> unsigned long flags;
> - DECLARE_WAITQUEUE(wait, current);
> + DEFINE_WAIT(wait);
> int cd;
>
> /* block if port is in the process of being closed */
Why is nobody reporting the oopses?
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2 1/1] Char: tty, fix tty_port_block_til_ready waiting
2009-06-23 23:30 ` Andrew Morton
@ 2009-06-24 11:41 ` Jiri Slaby
0 siblings, 0 replies; 3+ messages in thread
From: Jiri Slaby @ 2009-06-24 11:41 UTC (permalink / raw)
To: Andrew Morton; +Cc: alan, linux-kernel
On 06/24/2009 01:30 AM, Andrew Morton wrote:
> On Thu, 18 Jun 2009 09:46:13 +0200
>> --- a/drivers/char/tty_port.c
>> +++ b/drivers/char/tty_port.c
>> @@ -193,7 +193,7 @@ int tty_port_block_til_ready(struct tty_port *port,
>> {
>> int do_clocal = 0, retval;
>> unsigned long flags;
>> - DECLARE_WAITQUEUE(wait, current);
>> + DEFINE_WAIT(wait);
>> int cd;
>>
>> /* block if port is in the process of being closed */
>
> Why is nobody reporting the oopses?
Myaybe because only few drivers use that function. I hit it the first
time I tested cyclades patchset.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-06-24 11:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-18 7:46 [PATCH v2 1/1] Char: tty, fix tty_port_block_til_ready waiting Jiri Slaby
2009-06-23 23:30 ` Andrew Morton
2009-06-24 11:41 ` Jiri Slaby
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox