Re: Regression with commit f9cde5f in 2.6.30-gitX

Gary Hade
2009-06-24T16:13:20Z

On Wed, Jun 24, 2009 at 09:27:48PM +0530, Jaswinder Singh Rajput wrote:
> On Wed, 2009-06-24 at 17:19 +0200, Thomas Gleixner wrote:
> > Larry,
> >
> > On Wed, 24 Jun 2009, Larry Finger wrote:
> > > For the record, the printout from the patch results in the following:
> > >
> > > PCI: Failed to allocate 0xd0000-0xd3fff from PCI mem for PCI Bus 0000:00
> > > PCI: Failed to allocate 0xec000-0xeffff from PCI mem for PCI Bus
> > > 0000:00 due to _CRS returning more than 13 resource descriptors
> > > PCI: Failed to allocate 0xf0000-0xfffff from PCI mem for PCI Bus
> > > 0000:00 due to _CRS returning more than 13 resource descriptors
> > > PCI: Failed to allocate 0xc0000000-0xfebfffff from PCI mem for PCI Bus
> > > 0000:00 due to _CRS returning more than 13 resource descriptors
> >
> > can you please the patch below instead of the other one ?
> >
> > Thanks,
> >
> > tglx
> > ---
> > diff --git a/arch/x86/pci/acpi.c b/arch/x86/pci/acpi.c
> > index 16c3fda..39a0cce 100644
> > --- a/arch/x86/pci/acpi.c
> > +++ b/arch/x86/pci/acpi.c
> > @@ -99,7 +99,6 @@ setup_resource(struct acpi_resource *acpi_res, void *data)
> > "%d resource descriptors\n", (unsigned long) res->start,
> > (unsigned long) res->end, root->name, info->name,
> > max_root_bus_resources);
> > - info->res_num++;
> > return AE_OK;
> > }
> >
>
> This fails and system does not boot, I already tested this patch 8 hours
> ago.

I think the resource array needs to be larger. Can you try
the below patch?

Gary

--- linux-2.6.30-rc8/include/linux/pci.h.ORIG 2009-06-24 09:03:41.000000000 -0700
+++ linux-2.6.30-rc8/include/linux/pci.h 2009-06-24 09:06:50.000000000 -0700
@@ -319,7 +319,7 @@ static inline void pci_add_saved_cap(str
}

#ifndef PCI_BUS_NUM_RESOURCES
-#define PCI_BUS_NUM_RESOURCES 16
+#define PCI_BUS_NUM_RESOURCES 20
#endif

#define PCI_REGION_FLAG_MASK 0x0fU /* These bits of resource flags tell us the PCI region flags */