public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
	ray-lk@madrabbit.org, renton@renton.name,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: devpts mounts too slowly
Date: Wed, 24 Jun 2009 16:02:43 -0700	[thread overview]
Message-ID: <4A42B093.4070702@zytor.com> (raw)
In-Reply-To: <20090624145822.72aaaff6.akpm@linux-foundation.org>

Andrew Morton wrote:
>>>
>>> umounts do not appear affected; each umount still take negible time.
>> I think I know what's going on.  /sbin/mount is linked against libselinux
>> /sbin/umount is not.  And FPOS in question blows if you
>> 	* do not have selinuxfs mounted (e.g. because selinux is not enabled)
>> 	* have a lot of mounts.
>>
>> What happens is that this piece of crap checks for presence of selinuxfs
>> on /selinux; then, if the thing isn't there, we go and scan the entire
>> /proc/mounts in search of selinuxfs mounts.
>>
>> If akpm has selinux enabled on his testbox and you don't have it on yours,
>> we have all observations explained.
> 
> CONFIG_SECURITY_SELINUX=y
> CONFIG_SECURITY_SELINUX_BOOTPARAM=y
> CONFIG_SECURITY_SELINUX_BOOTPARAM_VALUE=1
> CONFIG_SECURITY_SELINUX_DISABLE=y
> CONFIG_SECURITY_SELINUX_DEVELOP=y
> CONFIG_SECURITY_SELINUX_AVC_STATS=y
> CONFIG_SECURITY_SELINUX_CHECKREQPROT_VALUE=1
> # CONFIG_SECURITY_SELINUX_ENABLE_SECMARK_DEFAULT is not set
> # CONFIG_SECURITY_SELINUX_POLICYDB_VERSION_MAX is not set
> 

Wow.  It doesn't even check for selinux actually being enabled before
embarking on this stupidity.

FAIL.

	-hpa

  reply	other threads:[~2009-06-24 23:03 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-03 14:28 devpts mounts too slowly Alexey Vlasov
2009-06-03 21:28 ` H. Peter Anvin
2009-06-09 23:19   ` Andrew Morton
2009-06-09 23:30     ` Ray Lee
2009-06-09 23:53       ` Andrew Morton
2009-06-10  0:07         ` H. Peter Anvin
2009-06-10 20:51         ` H. Peter Anvin
2009-06-24 20:01           ` Al Viro
2009-06-24 21:58             ` Andrew Morton
2009-06-24 23:02               ` H. Peter Anvin [this message]
2009-06-10  0:02       ` H. Peter Anvin
2009-07-06 19:52         ` Alexey Vlasov
2009-07-06 20:03           ` Alexey Vlasov
2009-07-06 21:21           ` H. Peter Anvin
2009-07-07  8:38             ` Alexey Vlasov
2009-07-07 15:37               ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A42B093.4070702@zytor.com \
    --to=hpa@zytor.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ray-lk@madrabbit.org \
    --cc=renton@renton.name \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox