From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755049AbZFXXiK (ORCPT ); Wed, 24 Jun 2009 19:38:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756605AbZFXXhv (ORCPT ); Wed, 24 Jun 2009 19:37:51 -0400 Received: from srv5.dvmed.net ([207.36.208.214]:39878 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756755AbZFXXht (ORCPT ); Wed, 24 Jun 2009 19:37:49 -0400 Message-ID: <4A42B8EF.1010100@garzik.org> Date: Wed, 24 Jun 2009 19:38:23 -0400 From: Jeff Garzik User-Agent: Thunderbird 2.0.0.21 (X11/20090320) MIME-Version: 1.0 To: Joe Perches CC: Alan Cox , linux-kernel@vger.kernel.org, kevin.huang@rdc.com.tw, greg@kroah.com, Linux IDE mailing list Subject: Re: [PATCH] pata_rdc: driver for RDC ATA devices References: <20090624172930.24354.80799.stgit@t61.ukuu.org.uk> <4A42800D.6020202@garzik.org> <20090624235548.681b8992@lxorguk.ukuu.org.uk> <1245886425.29098.117.camel@Joe-Laptop.home> In-Reply-To: <1245886425.29098.117.camel@Joe-Laptop.home> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.4 (----) X-Spam-Report: SpamAssassin version 3.2.5 on srv5.dvmed.net summary: Content analysis details: (-4.4 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Joe Perches wrote: > On Wed, 2009-06-24 at 23:55 +0100, Alan Cox wrote: >>> Seems fine and fairly straightforward to me. My lone comment -- go >>> through and replace magic numbers with named constants, for e.g. the PCI >>> config registers that program timings... >> Its based on your ata_piix driver. Feel free to update that and I'll pull >> names and things across to match. > > I sent a few patches to Jeff privately to do just that. > > I'm waiting for Jeff to see if he wants me to post > them publicly or not. Always post patches publicly... private mail is easily lost, left undiscussed and unarchived, etc. > Jeff, your email address in MAINTAINERS is jgarzik@pobox.com. > Should it be changed to redhat.com or garzik.org or left as is. MAINTAINERS is accurate :) Jeff