public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ftrace: remove duplicate newline
@ 2009-06-25  6:05 Li Zefan
  2009-06-25  8:31 ` [tip:tracing/urgent] ftrace: Remove " tip-bot for Li Zefan
  0 siblings, 1 reply; 3+ messages in thread
From: Li Zefan @ 2009-06-25  6:05 UTC (permalink / raw)
  To: Ingo Molnar; +Cc: Steven Rostedt, Frederic Weisbecker, LKML

Before:
  # echo 'sys_open:traceon:' > set_ftrace_filter
  # echo 'sys_close:traceoff:5' > set_ftrace_filter
  # cat set_ftrace_filter
  #### all functions enabled ####
  sys_open:traceon:unlimited

  sys_close:traceoff:count=0

After:
  # cat set_ftrace_filter
  #### all functions enabled ####
  sys_open:traceon:unlimited
  sys_close:traceoff:count=0

Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---
 kernel/trace/trace_functions.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/kernel/trace/trace_functions.c b/kernel/trace/trace_functions.c
index 90f1347..7402144 100644
--- a/kernel/trace/trace_functions.c
+++ b/kernel/trace/trace_functions.c
@@ -302,8 +302,7 @@ ftrace_trace_onoff_print(struct seq_file *m, unsigned long ip,
 	if (count == -1)
 		seq_printf(m, ":unlimited\n");
 	else
-		seq_printf(m, ":count=%ld", count);
-	seq_putc(m, '\n');
+		seq_printf(m, ":count=%ld\n", count);
 
 	return 0;
 }
-- 
1.5.4.rc3



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [tip:tracing/urgent] ftrace: Remove duplicate newline
  2009-06-25  6:05 [PATCH] ftrace: remove duplicate newline Li Zefan
@ 2009-06-25  8:31 ` tip-bot for Li Zefan
  2009-06-25 12:34   ` Steven Rostedt
  0 siblings, 1 reply; 3+ messages in thread
From: tip-bot for Li Zefan @ 2009-06-25  8:31 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: linux-kernel, hpa, mingo, fweisbec, rostedt, lizf, tglx, mingo

Commit-ID:  00e54d087afb3867b0b461aef6c1ff433d0df564
Gitweb:     http://git.kernel.org/tip/00e54d087afb3867b0b461aef6c1ff433d0df564
Author:     Li Zefan <lizf@cn.fujitsu.com>
AuthorDate: Thu, 25 Jun 2009 14:05:27 +0800
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Thu, 25 Jun 2009 10:28:36 +0200

ftrace: Remove duplicate newline

Before:
  # echo 'sys_open:traceon:' > set_ftrace_filter
  # echo 'sys_close:traceoff:5' > set_ftrace_filter
  # cat set_ftrace_filter
  #### all functions enabled ####
  sys_open:traceon:unlimited

  sys_close:traceoff:count=0

After:
  # cat set_ftrace_filter
  #### all functions enabled ####
  sys_open:traceon:unlimited
  sys_close:traceoff:count=0

Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
LKML-Reference: <4A4313A7.7030105@cn.fujitsu.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>


---
 kernel/trace/trace_functions.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/kernel/trace/trace_functions.c b/kernel/trace/trace_functions.c
index 90f1347..7402144 100644
--- a/kernel/trace/trace_functions.c
+++ b/kernel/trace/trace_functions.c
@@ -302,8 +302,7 @@ ftrace_trace_onoff_print(struct seq_file *m, unsigned long ip,
 	if (count == -1)
 		seq_printf(m, ":unlimited\n");
 	else
-		seq_printf(m, ":count=%ld", count);
-	seq_putc(m, '\n');
+		seq_printf(m, ":count=%ld\n", count);
 
 	return 0;
 }

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [tip:tracing/urgent] ftrace: Remove duplicate newline
  2009-06-25  8:31 ` [tip:tracing/urgent] ftrace: Remove " tip-bot for Li Zefan
@ 2009-06-25 12:34   ` Steven Rostedt
  0 siblings, 0 replies; 3+ messages in thread
From: Steven Rostedt @ 2009-06-25 12:34 UTC (permalink / raw)
  To: mingo, hpa, linux-kernel, fweisbec, lizf, tglx, mingo; +Cc: linux-tip-commits



On Thu, 25 Jun 2009, tip-bot for Li Zefan wrote:

> Commit-ID:  00e54d087afb3867b0b461aef6c1ff433d0df564
> Gitweb:     http://git.kernel.org/tip/00e54d087afb3867b0b461aef6c1ff433d0df564
> Author:     Li Zefan <lizf@cn.fujitsu.com>
> AuthorDate: Thu, 25 Jun 2009 14:05:27 +0800
> Committer:  Ingo Molnar <mingo@elte.hu>
> CommitDate: Thu, 25 Jun 2009 10:28:36 +0200
> 
> ftrace: Remove duplicate newline
> 
> Before:
>   # echo 'sys_open:traceon:' > set_ftrace_filter
>   # echo 'sys_close:traceoff:5' > set_ftrace_filter
>   # cat set_ftrace_filter
>   #### all functions enabled ####
>   sys_open:traceon:unlimited
> 
>   sys_close:traceoff:count=0
> 
> After:
>   # cat set_ftrace_filter
>   #### all functions enabled ####
>   sys_open:traceon:unlimited
>   sys_close:traceoff:count=0
> 
> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
> Cc: Steven Rostedt <rostedt@goodmis.org>

Thanks!

Acked-by: Steven Rostedt <rostedt@goodmis.org>

-- Steve

> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> LKML-Reference: <4A4313A7.7030105@cn.fujitsu.com>
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
> 
> 
> ---
>  kernel/trace/trace_functions.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/trace/trace_functions.c b/kernel/trace/trace_functions.c
> index 90f1347..7402144 100644
> --- a/kernel/trace/trace_functions.c
> +++ b/kernel/trace/trace_functions.c
> @@ -302,8 +302,7 @@ ftrace_trace_onoff_print(struct seq_file *m, unsigned long ip,
>  	if (count == -1)
>  		seq_printf(m, ":unlimited\n");
>  	else
> -		seq_printf(m, ":count=%ld", count);
> -	seq_putc(m, '\n');
> +		seq_printf(m, ":count=%ld\n", count);
>  
>  	return 0;
>  }
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2009-06-25 12:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-25  6:05 [PATCH] ftrace: remove duplicate newline Li Zefan
2009-06-25  8:31 ` [tip:tracing/urgent] ftrace: Remove " tip-bot for Li Zefan
2009-06-25 12:34   ` Steven Rostedt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox