From: Gregory Haskins <ghaskins@novell.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Gregory Haskins <ghaskins@novell.com>,
avi@redhat.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, mtosatti@redhat.com,
paulmck@linux.vnet.ibm.com, markmc@redhat.com
Subject: Re: [PATCH] kvm: remove in_range from kvm_io_device
Date: Thu, 25 Jun 2009 09:19:25 -0400 [thread overview]
Message-ID: <4A43795D.1080501@novell.com> (raw)
In-Reply-To: <20090625131633.GA7221@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 856 bytes --]
Michael S. Tsirkin wrote:
> On Thu, Jun 25, 2009 at 09:02:28AM -0400, Gregory Haskins wrote:
>
>>> Here's what I have in mind:
>>> kvm does
>>> lock
>>> dev = find
>>> unlock
>>>
>>> <---------- at this point group device is removed
>>>
>>> write access to device that has been removed
>>>
>>>
>>>
>>>
>> Hmm...you are right. This looks like it was introduced with that recent
>> locking patch you cited. Well, I can still fix it now easily by putting
>> an rcu-read-lock around the access. Longer term we should move to
>> srcu. Thoughts?
>>
>> -Greg
>>
>>
>
>
> Some callbacks take kvm mutex lock. So it seems rcu won't work,
> we need srcu.
>
>
Indeed. I will put something together.
We should consider merging the io_bus cleanup I have for deregister
support ASAP as well.
-Greg
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 266 bytes --]
next prev parent reply other threads:[~2009-06-25 13:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-23 15:00 [PATCH] kvm: remove in_range from kvm_io_device Michael S. Tsirkin
2009-06-23 15:21 ` Gregory Haskins
2009-06-23 15:31 ` Michael S. Tsirkin
2009-06-23 15:44 ` Gregory Haskins
2009-06-23 15:56 ` Michael S. Tsirkin
2009-06-23 16:14 ` Gregory Haskins
2009-06-24 1:43 ` Gregory Haskins
2009-06-24 8:49 ` Michael S. Tsirkin
2009-06-25 11:08 ` Michael S. Tsirkin
2009-06-25 11:27 ` Gregory Haskins
2009-06-25 11:54 ` Michael S. Tsirkin
2009-06-25 12:08 ` Gregory Haskins
2009-06-25 12:37 ` Michael S. Tsirkin
2009-06-25 13:02 ` Gregory Haskins
2009-06-25 13:16 ` Michael S. Tsirkin
2009-06-25 13:19 ` Gregory Haskins [this message]
2009-06-28 12:07 ` Avi Kivity
2009-06-25 15:45 ` Gregory Haskins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A43795D.1080501@novell.com \
--to=ghaskins@novell.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markmc@redhat.com \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox