Re: [PATCH] net: fix race in the receive/select

Eric Dumazet
2009-06-26T19:36:42Z

David Miller a écrit :
> From: Davide Libenzi <davidel@xmailserver.org>
> Date: Fri, 26 Jun 2009 11:12:15 -0700 (PDT)
>
>> On Fri, 26 Jun 2009, Oleg Nesterov wrote:
>>
>>> Perhaps we can add
>>>
>>> void sock_poll_wait(struct file *file, struct sock *sk, poll_table *pt)
>>> {
>>> if (pt) {
>>> poll_wait(file, sk->sk_sleep, pt);
>>> /*
>>> * fat comment
>>> */
>>> smp_mb(); // or smp_mb__after_unlock();
>>> }
>>> }
>> That'd be fine IMHO. Are DaveM and Eric OK?
>
> No objections from me.

Very good :)

Jiri, please respin a patch with this idea from Oleg

(We'll have to check all calls to poll_wait() in net tree)

Thanks everybody