public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Jaswinder Singh Rajput <jaswinder@kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Randy Dunlap <randy.dunlap@oracle.com>,
	Russell King <rmk+lkml@arm.linux.org.uk>,
	benh@kernel.crashing.org, paulus@samba.org
Subject: Re: [PATCH] gitignore: add *.bz2 and *.cpio to top-level; clean up usr/
Date: Fri, 26 Jun 2009 15:51:41 -0700	[thread overview]
Message-ID: <4A4550FD.7020806@zytor.com> (raw)
In-Reply-To: <20090626224321.GA27310@uranus.ravnborg.org>

Sam Ravnborg wrote:
> 
> My concern is that we may decide to carry files in certain formats
> in the kernel source.
> And I see a tendency to add more and more file extensions to the
> top-level .gitignore file.
> 
> It is fine as long as this is files that are:
> 1) either generated in a lot of places
> 2) or generated in the top-level directory
> 
> But files that we generate in a few arch/*/boot/ directories
> does not belong in the top-level .gitignore file.
> We should keep the ignore rules close to where they apply,
> even if this may cause us to add a few more lines
> to the relevant .gitignore files.
> 

Honestly, I think this is ridiculous.  A single well-maintained
.gitignore file is a *service* to the whole tree, and the last thing we
want is git to behave differently in different subdirectories.

It is *much better* to have global rules, and add exceptions out in the
leaves of the tree where they apply.  The question that the global
.gitignore should answer is:

"If I have a file of type X, is the user *likely* to want to actually
want it in the tree?"

In the case of *.gz *.bz2 *.lzma or *.cpio, I think the answer is a
resounding "no".  Almost every architecture uses compressed files at
some stage of its boot, and it's *always* a generated file.  A
non-generated file is probably a patch being handled by a developer, not
something that is meant to be in the tree.

I'm not saying we wouldn't *ever* want to have compressed binary blobs
in the tree -- there are actually a handful of reasons to do so -- but
*those are the exceptions*, and therefore should be using !-rules in
their respective .gitignores, instead of requiring that the entire tree
suffers from less sensible defaults.

	-hpa

  reply	other threads:[~2009-06-26 22:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-20 20:52 [PATCH] gitignore: add *.bz2 and *.cpio to top-level; clean up usr/ H. Peter Anvin
2009-06-21  7:32 ` Jaswinder Singh Rajput
2009-06-26 22:21   ` Sam Ravnborg
2009-06-26 22:23     ` H. Peter Anvin
2009-06-26 22:43       ` Sam Ravnborg
2009-06-26 22:51         ` H. Peter Anvin [this message]
2009-06-27  7:47           ` Sam Ravnborg
2009-06-27  8:41             ` Jaswinder Singh Rajput
2009-06-30  1:30             ` H. Peter Anvin
2009-06-26 22:30     ` H. Peter Anvin
2009-06-26 22:31     ` Jaswinder Singh Rajput
2009-06-26 22:46       ` Sam Ravnborg
2009-06-26 22:51         ` Jaswinder Singh Rajput
2009-06-26 22:26   ` Jaswinder Singh Rajput

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A4550FD.7020806@zytor.com \
    --to=hpa@zytor.com \
    --cc=benh@kernel.crashing.org \
    --cc=jaswinder@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulus@samba.org \
    --cc=randy.dunlap@oracle.com \
    --cc=rmk+lkml@arm.linux.org.uk \
    --cc=sam@ravnborg.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox