Re: [PATCH] SCSI: userspace cannot use scsi_command_size_tbl, COMMAND_SIZE and scsi_device_type

[James Smart <James.Smart@Emulex.Com>]

Sorry folks --  the nuance of the clibrary having it's own version of a 
kernel header for distros was completely unknown to me.

Christoph mentioned this to me last week, with the recommendation to 
back out the patch and move the other headers that were exprted into 
include/linux - thus nothing in include/scsi gets export.  No Problem. 
and I'll do so shortly.

How does a lowly contributor track these kind of nuances ?

-- james s



Boaz Harrosh wrote:
> On 06/27/2009 08:05 PM, Jaswinder Singh Rajput wrote:
>   
>> userspace cannot use scsi_command_size_tbl, COMMAND_SIZE
>> and scsi_device_type defined in kernel
>>
>> fix the following 'make headers_check' warnings:
>>
>>   usr/include/scsi/scsi.h:159: userspace cannot call function or variable defined in the kernel
>>   usr/include/scsi/scsi.h:285: userspace cannot call function or variable defined in the kernel
>>
>> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
>>     
>
> include/scsi/scsi.h was always provided by glibc and was never exported from Kernel.
> It was only recently added to include/scsi/Kbuild. (In this merge window, was never released)
> (see: [9e4f5e29] [SCSI] FC Pass Thru support)
>
> Two questions. 
> 1. Are we sure this will work. Is the Header fully compatible with glibc's header.
> 2. What will this do to distor's package managers having the same file in two packages?
>    Don't we need a followup patch sent to glibc to remove that Header from there?
>
> James Smart
>   What is the new definitions needed in user-mode in scsi.h that is not available in glibc's
> supplied header?
>
> (For reference see this patch from 2007: [e629a7dd] do not export /usr/include/scsi in make headers_install)
>
> Boaz
>