public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [patch] mm: remove obsoleted alloc_pages cpuset comment
@ 2009-06-25 20:48 David Rientjes
  2009-06-28 14:52 ` Miao Xie
  0 siblings, 1 reply; 2+ messages in thread
From: David Rientjes @ 2009-06-25 20:48 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Paul Menage, Miao Xie, linux-kernel

When a cpuset's nodemask is updated, all attached tasks have their cached
task->mems_allowed updated by a heap instead of requiring an explicit
call to cpuset_update_task_memory_state(), which has since been removed
in 58568d2a8215cb6f55caf2332017d7bdff954e1c.

Remove the obsoleted comment from the page allocator.

Cc: Paul Menage <menage@google.com>
Cc: Miao Xie <miaox@cn.fujitsu.com>
Signed-off-by: David Rientjes <rientjes@google.com>
---
 mm/page_alloc.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 5d714f8..8670fb7 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -1620,10 +1620,6 @@ __alloc_pages_direct_reclaim(gfp_t gfp_mask, unsigned int order,
 
 	/* We now go into synchronous reclaim */
 	cpuset_memory_pressure_bump();
-
-	/*
-	 * The task's cpuset might have expanded its set of allowable nodes
-	 */
 	p->flags |= PF_MEMALLOC;
 	lockdep_set_current_reclaim_state(gfp_mask);
 	reclaim_state.reclaimed_slab = 0;

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [patch] mm: remove obsoleted alloc_pages cpuset comment
  2009-06-25 20:48 [patch] mm: remove obsoleted alloc_pages cpuset comment David Rientjes
@ 2009-06-28 14:52 ` Miao Xie
  0 siblings, 0 replies; 2+ messages in thread
From: Miao Xie @ 2009-06-28 14:52 UTC (permalink / raw)
  To: David Rientjes; +Cc: Andrew Morton, Paul Menage, linux-kernel

> When a cpuset's nodemask is updated, all attached tasks have their cached
> task->mems_allowed updated by a heap instead of requiring an explicit
> call to cpuset_update_task_memory_state(), which has since been removed
> in 58568d2a8215cb6f55caf2332017d7bdff954e1c.
> 
> Remove the obsoleted comment from the page allocator.

Sorry. It's my mistake. Thanks for your fix.

Acked-by: Miao Xie <miaox@cn.fujitsu.com>

> 
> Cc: Paul Menage <menage@google.com>
> Cc: Miao Xie <miaox@cn.fujitsu.com>
> Signed-off-by: David Rientjes <rientjes@google.com>
> ---
>  mm/page_alloc.c |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 5d714f8..8670fb7 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -1620,10 +1620,6 @@ __alloc_pages_direct_reclaim(gfp_t gfp_mask, unsigned int order,
>  
>  	/* We now go into synchronous reclaim */
>  	cpuset_memory_pressure_bump();
> -
> -	/*
> -	 * The task's cpuset might have expanded its set of allowable nodes
> -	 */
>  	p->flags |= PF_MEMALLOC;
>  	lockdep_set_current_reclaim_state(gfp_mask);
>  	reclaim_state.reclaimed_slab = 0;
> 
> 
> 



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-06-28 14:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-25 20:48 [patch] mm: remove obsoleted alloc_pages cpuset comment David Rientjes
2009-06-28 14:52 ` Miao Xie

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox